feat: introduce devMode to support nodejs based unit testing #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiscoding
reviewed
Dec 7, 2023
| @@ -108,6 +108,9 @@ export interface GridOption<C extends BaseColumn = BaseColumn> { | |||
| /** Default cell Formatter that will be used by the grid */ | |||
| defaultFormatter?: Formatter; | |||
|
|
|||
| /** Escape hatch geared towards testing Slickgrid in jsdom based environments to circumvent the lack of stylesheet.ownerNode and clientWidth calculations */ | |||
| devMode?: false & { ownerNodeIndex?: number; containerClientWidth?: number; }; | |||
There was a problem hiding this comment.
@zewa666 isn't that supposed to be | instead of &, because it can never be both false and an object at the same time
There was a problem hiding this comment.
its an intersection, so a type being either false or object. with an union you'd get a compile error due to false and obj not sharing enough (false does not exist on type ...)
There was a problem hiding this comment.
I also tried it on my side and that worked with | but ok if you're sure then let's merge. Thanks for confirming. I'll copy that code to next slickgrid-universal too since I'll soon have my own slickgrid/dataview in my repo
ghiscoding
added a commit
to ghiscoding/slickgrid-universal
that referenced
this pull request
Dec 7, 2023
- copies implementation made in 6pac/SlickGrid repo at 6pac/SlickGrid#946 > as the title suggests this is meant to make unit/integration tests, e.g with testing-library, possible for apps using Slickgrid. In my specific case I'm making use of angular-slickgrid and would like to be able to test my app using angular-testing-library. > > The introduced devMode workarounds are in order to work around the following jsdom issues: > > [jsdom/jsdom#2310](jsdom/jsdom#2310) (missing clientWidth) [jsdom/jsdom#992](jsdom/jsdom#992) (missing ownerNode, even with a nice reference to Slickgrid ;) ) For additional conversations about this topic please refer to [ghiscoding/Angular-Slickgrid#1319](ghiscoding/Angular-Slickgrid#1319)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the title suggests this is meant to make unit/integration tests, e.g with testing-library, possible for apps using Slickgrid. In my specific case I'm making use of angular-slickgrid and would like to be able to test my app using angular-testing-library.
The introduced devMode workarounds are in order to work around the following jsdom issues:
jsdom/jsdom#2310 (missing clientWidth)
jsdom/jsdom#992 (missing ownerNode, even with a nice reference to Slickgrid ;) )
For additional conversations about this topic please refer to ghiscoding/Angular-Slickgrid#1319