-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update commands based on Kakoune 2022.10.31 #281
Comments
The {
"key": ",",
"command": "dance.selections.clear.secondary",
"when": "editorTextFocus && dance.mode == 'normal'"
},
{
"key": "space",
"command": "-dance.selections.clear.secondary",
"when": "editorTextFocus && dance.mode == 'normal'"
},
{
"key": "alt+,",
"command": "dance.selections.clear.main",
"when": "editorTextFocus && dance.mode == 'normal'"
},
{
"key": "alt+space",
"command": "-dance.selections.clear.main",
"when": "editorTextFocus && dance.mode == 'normal'"
},
{
"key": "space",
"command": "whichkey.show",
"when": "editorTextFocus && dance.mode == 'normal'"
},
|
What about the other changes?
Then Also, I've been using Kakoune from master for some time now, and when I have to use VS Code, there's a bit of friction. Thank you for this plugin! |
I'd like to somehow keep both old and new Kakoune keybindings (or document the previous ones). I personally like (and use) the old Given that macros still are kinda experimental in Dance, I'd like to keep I use Thanks for listing the different changes! |
I think maybe keeping That's the only thing I miss from the latest Kakoune release: selecting lines with Now we have to I've mapped |
Do you use it even to go down the lines, selecting one at a time, or do you use the I've never used |
I'm one of the people who use the "real" kakoune for basic editing, and this vscode extension when I'm coding (for work and hobbies). I'd like to propose using the same bindings as kakoune, for consistency. I realize that it might not be a goal of this extension to be compatible or consistent with kakoune proper, but just to mimic it. But from my perspective it's very useful to be as similar as possible, for consistency. Hear me out. So old behavior would be:
In this method, there's no way to use In the new method by kakoune upstream, you'd just do this:
The workflow becomes similar for both directions which makes it easy to remember, thus worth relearning. This is my two cents, I hope I made somewhat of a strong case and that you agree -- because this is by far the best kakoune "emulator" on the marketplace right now in my honest opinion. You've done a great job with it so far! |
Good explanation. Now that I understand, I like the idea of the new |
@victorz Thanks for the thorough explanation! I definitely see the advantage in the new workflow now. To be clear, in any case I'd like to stay consistent with Kakoune. My objective for Dance 0.6 is to have different layouts you can choose from, Kakoune being one of them (and later perhaps Helix, and a "Dance-flavored Kakoune" (edit: for instance, for the new For the time being, the new usage of |
Also fix issues with `.selections.trimLines` and `.selections.expandToLines` and upgrade `typescript`.
Only |
Amazing, thank you! And my pleasure!
That sounds great! No worries, I have a whole career to wait for it.
I do actually! A really good reason to not have Esc stopping recording is the simple fact that a macro might want to include changing modes to normal mode to do other operations. The same reason why macros in vim are also handled this way -- only the key that starts defining a macro can also stop defining a macro. I hope that makes sense! 🙂 |
I just tried that, and if you are recording a macro and are in insert mode, won't stop recording the macro, but put you in normal mode instead. |
Ah, right, as @arrufat said Macros are kinda broken in Dance, so even though removing the |
ec90111 fixes |
Kakoune 2022.10.31 remaps several commands available in Dance. Should we update these commands in Dance as well? IMO, we should.
The text was updated successfully, but these errors were encountered: