Schemas that have a name with a '-' character in them cause invalid code to be generated

[wxyangf]

eg:

"Schema-Name": {
  "id": {
         "type": "integer",
          "title": "Id"
    }
   ...
}

Will generate code that looks like this:

export const $Schema-Name= {
    properties: {
        id: {
            type: 'integer',
            title: 'Id'
        }
        ...
     }

Dashes are not valid characters for javascript variable names, but are valid strings for json keys.

Not sure the best way to deal with this, maybe export an object instead, mangle to a _ or just explicitly not support having - in schema names and add a test for that.

[seriouslag]

Thank you for opening an issue.

If you don't need the schemas you can pass false to the generate schema option.

This was an issue with @hey-api/openapi-ts.
Fixed in version 0.39

We will need to update. They have changed many APIs in the meantime, may take some time.

[wxyangf]

Thanks for taking a look at this so quickly!

I was planning on working around this by changing my backend openapi generation -- but I figured it would be good to get the bug report in.

Sorry, but how do you disable schema generation? It doesn't seem to be an option in the cli invocation?

[seriouslag]

Thanks for taking a look at this so quickly!

I was planning on working around this by changing my backend openapi generation -- but I figured it would be good to get the bug report in.

Sorry, but how do you disable schema generation? It doesn't seem to be an option in the cli invocation?

Sorry seems, we didn't expose that option.
I opened a PR #84 to update @hey-api/openapi-ts which fixes the schema issue.
I also added the CLI option, --noSchemas so we can disable schema generation in the future.

[Corepex]

eg:

"Schema-Name": {
  "id": {
         "type": "integer",
          "title": "Id"
    }
   ...
}

Will generate code that looks like this:

export const $Schema-Name= {
    properties: {
        id: {
            type: 'integer',
            title: 'Id'
        }
        ...
     }

Dashes are not valid characters for javascript variable names, but are valid strings for json keys.

Not sure the best way to deal with this, maybe export an object instead, mangle to a _ or just explicitly not support having - in schema names and add a test for that.

faced the same issue for e.g. $AccessToken.jsonld-user.read

[seriouslag]

This was fixed in 1.2.0

[Corepex]

works now for me - updated yesterday 💯