fix(exports): strip referenced imports of models #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seriouslag Is there any specific case I can reproduce? I would like to try reproducing it on my PC. |
I was able to duplicate the issue with this file. |
seriouslag
force-pushed
the
fix/handle-referenced-imports
branch
from
044a1af
to
edbd14b
Compare
seriouslag
changed the title
seriouslag
force-pushed
the
fix/handle-referenced-imports
branch
from
edbd14b
to
b0b88b6
Compare
The reference import path isn't needed as we import all Models into the file already
seriouslag
force-pushed
the
fix/handle-referenced-imports
branch
from
b0b88b6
to
ec2e3f0
Compare
7nohe
approved these changes
Apr 20, 2024
This was referenced Apr 22, 2024
seriouslag
added a commit
that referenced
this pull request
Apr 22, 2024
- Update to the latest `@hey-api/openapi-ts` version `0.42.1`
- Fixed a bug where types in mutation hooks were imported from a (non-relative) direct file import.
- This is the same fix implemented in #61, which was done for query hooks.
- Fixed a bug where JSDocs were not being added to generated hooks.
- Add more unit tests
Fixes: #83
Enables work towards: #81
seriouslag
added a commit
that referenced
this pull request
Apr 23, 2024
- Update to the latest `@hey-api/openapi-ts` version `0.42.1` - fixes: #83, - Enables work towards #81 - Fixed a bug where types in mutation hooks were imported from a (non-relative) direct file import. - This is the same fix implemented in #61, which was done for query hooks. - Expand the match regex to take account of non-alphabetical file paths - fixes: #85 - Fixed a bug where JSDocs were not being added to generated hooks. - Add more unit testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference import path isn't needed as we have already imported all models into the file in question.
This fixes a bug I am having where the entire type with import is being put where a type is located.
The big issue with this import is that it is an absolute path on the computer that generated the code. This is an issue when we want to deploy the code in a library.
This changes:
to
I would love to find another way to solve this, as this seems like a hack, but I am still looking for a solution.
A similar change may need to be added to the mutation queries but I do not have an example.