Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loud comments #101

Merged
merged 3 commits into from
Apr 17, 2017
Merged

Add support for loud comments #101

merged 3 commits into from
Apr 17, 2017

Conversation

simoneldevig
Copy link
Contributor

It is very important the add support for loud comments when working in production environments since normal comments are removed when compiling sass with as compressed.

@7rulnik
Copy link
Owner

7rulnik commented Apr 4, 2017

@simoneldevig hi! Thank you for PR.
I think we can use String.prototype.includes instead of two equality checks. Can you do it?

@7rulnik 7rulnik self-assigned this Apr 5, 2017
@simoneldevig
Copy link
Contributor Author

@7rulnik I've tried to change it to use includes, but since the text that does not contain flexibility-disable is undefined it means that it would require an ekstra check anyways? :-)

@7rulnik
Copy link
Owner

7rulnik commented Apr 6, 2017

@simoneldevig you can use default argument rule.some(({prop, text = ''}) =>

@coveralls
Copy link

coveralls commented Apr 8, 2017

Coverage Status

Changes Unknown when pulling 84cced6 on nozebra:loud-comment-support into ** on 7rulnik:master**.

@coveralls
Copy link

coveralls commented Apr 8, 2017

Coverage Status

Changes Unknown when pulling 84cced6 on nozebra:loud-comment-support into ** on 7rulnik:master**.

@simoneldevig
Copy link
Contributor Author

@7rulnik I've changed the check to use endsWith since I ran in some issues with includes on not loud comments. I also added a test for loud comments as well :-)

@7rulnik
Copy link
Owner

7rulnik commented Apr 14, 2017

@simoneldevig nice! Thank you for tests. I will merge and release it at saturday.

@7rulnik 7rulnik merged commit 775a323 into 7rulnik:master Apr 17, 2017
@7rulnik
Copy link
Owner

7rulnik commented Apr 17, 2017

@simoneldevig just released it in 1.0.1. Thanks!

@simoneldevig simoneldevig deleted the loud-comment-support branch April 18, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants