Some openSUSE improvement

[dfaggioli]

This pull request does the following:

1. fix openSUSE systemd (i.e., --init) enabled distrobox
2. customize openSUSE images during init, for enabling recommended packages
3. make it possible to keep recommended packages disabled --if one really wants that-- and do it in a way that is generic and can be used by other distroboxes and for other things

About 2 and 3, the first enter in a distrobox with is now quite a bit slower (because zypper is quite slow itself :-( ), but I think it's worth it. In fact, the resulting distrobox is now actually useful. E.g., GUI apps (but also non-GUI apps, as even just vim has problem withou recommended packages!) now works pretty much out of the box, once installed.

For comparison, I've created a Tumbleweed based distrobox, installed neofetch, vim and gedit, and it has ~600 packages. I've done the same on a rawhide one, and it has a little less than 500. So I think, all in all, it's fine, and well worth it.

[89luca89]

Hi @dfaggioli thanks for the PR!

I was thinking, would it be better to default to something more generic like

${DBX_CONTAINER_UNMINIMIZE}

The upside would be easier documentation (one var for all distros) and we can use it to unminimize also Ubuntu Debian and Fedora (which I can add later after this PR ) 👍

[dfaggioli]

Mmm... interesting, on openSUSE, something is now trying to install parallel-printer-support (really?!?!), which is trying to create stuff like /dev/lp0, and failing. This only happens with the toolbox image (which is why I didn't see, as I focused my testing on Tumbleweed)... Not sure why.

The most of the dependencies come from vte, and the packages are installed before marking /dev as a net-share. But we can't move all the package handling after that, because we need some of those packages there very early.

I can try to split packages installation in two steps. The second one (which for know would only contain vte packages, but I guess other packages, in future, may need the same treatment) will happen later, after mounts have been marked.

[dfaggioli]

I can try to split packages installation in two steps. The second one (which for know would only contain vte packages, but I guess other packages, in future, may need the same treatment) will happen later, after mounts have been marked.

Nope, I've just tested this, and it still does not work.

The only solution I'm seeing right now, is to lock out the parallel-printer-support package. Not being able to install such package inside a distrobox does not seem a big deal at all to me... So I'm updating the pull request to that effect.

If anyone see a better solution, I'm all ears :-D

[dfaggioli]

Hi @dfaggioli thanks for the PR!

I was thinking, would it be better to default to something more generic like

${DBX_CONTAINER_UNMINIMIZE}

Ok, I can do that.

One question: do I keep the DBX_CONTAINER_INIT_ prefix, for the variable name, and then only define in the environment the variables that have that prefix (as I'm doing right now)?

Or shall I just drop the _INIT_ part, and just put in the env all the DBX_CONTAINER_ variables? If we're making this generic, I'm thinking this second solution would be just fine, but I'm happy to do it the way you like it better. :-)

[89luca89]

Hi @dfaggioli thanks for the PR!
I was thinking, would it be better to default to something more generic like
${DBX_CONTAINER_UNMINIMIZE}

Ok, I can do that.

One question: do I keep the DBX_CONTAINER_INIT_ prefix, for the variable name, and then only define in the environment the variables that have that prefix (as I'm doing right now)?

Or shall I just drop the _INIT_ part, and just put in the env all the DBX_CONTAINER_ variables? If we're making this generic, I'm thinking this second solution would be just fine, but I'm happy to do it the way you like it better. :-)

I think droppint INIT is fine, after this I think I'll make it also a command line flag (--unminimize something like that) so that it can also be configured in the conf files and so on 👍

[89luca89]

I can try to split packages installation in two steps. The second one (which for know would only contain vte packages, but I guess other packages, in future, may need the same treatment) will happen later, after mounts have been marked.

Nope, I've just tested this, and it still does not work.

The only solution I'm seeing right now, is to lock out the parallel-printer-support package. Not being able to install such package inside a distrobox does not seem a big deal at all to me... So I'm updating the pull request to that effect.

If anyone see a better solution, I'm all ears :-D

Doubt that we need parallel printer in a container 🤔 so maybe blocking it is ok I guess

[dfaggioli]

I was thinking, would it be better to default to something more generic like

${DBX_CONTAINER_UNMINIMIZE}

The upside would be easier documentation (one var for all distros) and we can use it to unminimize also Ubuntu Debian and Fedora (which I can add later after this PR ) +1

Hey, me again, and sorry for bothering. I was back working on this, and I can't convince myself to like "unminimize", mostly because of the "inverted logic".

How about we call it something like DBX_CONTAINER_MINIMIZE or DBX_CONTAINER_MINIMAL_IMAGE ? Then, for openSUSE, I'd just set onlyRequires to true, unless I find that the variable is set to true (or 1).

It seems to me that this could work well also for other distros. In fact, AFAICT, Fedora installs soft dependency by default already, so one could just handle it in a similar way...

That said, if doing things this way is, for some reason that I don't see, unideal, or if you don't like, I'll go for UNMINIMIZE... Just let me know. :-)

[89luca89]

I was thinking, would it be better to default to something more generic like
${DBX_CONTAINER_UNMINIMIZE}
The upside would be easier documentation (one var for all distros) and we can use it to unminimize also Ubuntu Debian and Fedora (which I can add later after this PR ) +1

Hey, me again, and sorry for bothering. I was back working on this, and I can't convince myself to like "unminimize", mostly because of the "inverted logic".

How about we call it something like DBX_CONTAINER_MINIMIZE or DBX_CONTAINER_MINIMAL_IMAGE ? Then, for openSUSE, I'd just set onlyRequires to true, unless I find that the variable is set to true (or 1).

It seems to me that this could work well also for other distros. In fact, AFAICT, Fedora installs soft dependency by default already, so one could just handle it in a similar way...

That said, if doing things this way is, for some reason that I don't see, unideal, or if you don't like, I'll go for UNMINIMIZE... Just let me know. :-)

I was thinking the same to be honest 😄
Generally speaking I was thinking that UNMINIMIZE should be default, distrobox use cases is to have a usable userland, so having minimized containers, does not make a lot of sense

So maybe, without bothering to check variables, just unminimize it?

[dfaggioli]

How about we call it something like DBX_CONTAINER_MINIMIZE or DBX_CONTAINER_MINIMAL_IMAGE ? Then, for openSUSE, I'd just set onlyRequires to true, unless I find that the variable is set to true (or 1).
It seems to me that this could work well also for other distros. In fact, AFAICT, Fedora installs soft dependency by default already, so one could just handle it in a similar way...
That said, if doing things this way is, for some reason that I don't see, unideal, or if you don't like, I'll go for UNMINIMIZE... Just let me know. :-)

I was thinking the same to be honest smile

:-)

Generally speaking I was thinking that UNMINIMIZE should be default, distrobox use cases is to have a usable userland, so having minimized containers, does not make a lot of sense

Totally agree!

So maybe, without bothering to check variables, just unminimize it?

You mean we just get rid of it entirely?

[89luca89]

You mean we just get rid of it entirely?

The variable yes, we can just add the de-minimization inside the zypper section, and should be ok
After that I'll do the same for the other distributions/package managers

[89luca89]

I'd put the conf manipulation just before the shell_pkg installation, so we ensure that all the base dependencies are installed with recommends and docs 👍

[89luca89]

@dfaggioli
I'd also check for:

rpm.install.excludedocs=yes

That also is really useful to unminimize 👍

[dfaggioli]

@dfaggioli I'd also check for:

rpm.install.excludedocs=yes

That also is really useful to unminimize +1

Heh, we indeed do that as well (at least for Tumbleweed images... but not for toolbox images):

https://build.opensuse.org/package/view_file/openSUSE:Factory/opensuse-tumbleweed-image/config.sh?expand=1

[89luca89]

Cool all green now 😄 merging!
Thanks for the contribution!