Fix distrobox-export --bin error handling #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check that `--export-path` is also passed fails because the `dest_path` variable used to store the argument does not have a default value. Fixes 89luca89#274 ```shell distrobox on fix-export-bin [!] ⬢ [fedora-toolbox:36] ❯ distrobox-export --bin /usr/bin/fedpkg /usr/bin/distrobox-export: line 205: dest_path: unbound variable An error occurred ``` ```shell distrobox on fix-export-bin [!] ⬢ [fedora-toolbox:36] ❯ distrobox-export --bin /usr/bin/fedpkg Error: Missing argument export-path. An error occurred distrobox on fix-export-bin [!] ⬢ [fedora-toolbox:36] ❯ distrobox-export --bin /usr/bin/fedpkg --export-path ~/bin /usr/bin/fedpkg from f36-packaging exported successfully in /home/michel/bin. OK! ``` Signed-off-by: Michel Alexandre Salim <michel@michel-slm.name>
|
Thanks a lot @michel-slm ! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check that
--export-pathis also passed fails because thedest_pathvariable used to store the argument does not have adefault value.
Fixes #274
distrobox on fix-export-bin [!] ⬢ [fedora-toolbox:36] ❯ distrobox-export --bin /usr/bin/fedpkg /usr/bin/distrobox-export: line 205: dest_path: unbound variable An error occurredSigned-off-by: Michel Alexandre Salim michel@michel-slm.name