create: config to pull latest image by default

[juhp]

This is a potential solution to #288, which gives
the user the chance to always create a new toolbox with
the latest most current image, instead of an old out-dated one.

[89luca89]

Hi @juhp thanks!
Will test a bit the changes 👍

[89luca89]

Using it a bit, we might want to change a bit the behavior on this

Right now, every time I create it asks you want to pull? y/N
This does not make a lot of sense in the optics of having always the latest image
And more confusing is, if I say No, it creates the container if the image is present, which is a bit confusing

So either we could (as you proposed in #289 ) to have a --pull flag, which can be forgetful
or we could implement an ENV variable + config for container_always_pull for this

That would also set the non_interactive to 1, so that it does not ask questions

What do you think?

[juhp]

Thanks for testing - I only really tried the default interactive case myself so far.

Right now, every time I create it asks you want to pull? [Y/n]

Correct

This does not make a lot of sense in the optics of having always the latest image

Do you mean it doesn't make sense if one already has the latest?
Well that is true, but it is hard to detect, so IMHO it is easier to always attempt to pull.

And more confusing is, if I say No, it creates the container if the image is present, which is a bit confusing

So now "No" meant don't pull a new image (it is pretty similar to the old behavior with an existing image).

So either we could (as you proposed in #289 ) to have a --pull flag, which can be forgetful or we could implement an ENV variable + config for container_always_pull for this

Okay, thanks, sounds good enough to me, let's try that then.
Then one doesn't even have to answer the prompt which is even better really (once setup).

[89luca89]

Thanks for testing - I only really tried the default interactive case myself so far.

Thanks to you for the PR 😄

Okay, thanks, sounds good enough to me, let's try that then. Then one doesn't even have to answer the prompt which is even better really (once setup).

Yep should be less confusing, maintaining the current behavior (in main so don't pull if present) and bypass it only in case of config and/or ENV variable

[juhp]

How about this then?

[89luca89]

How about this then?

Great exactly what I was thinking 😄

There is one error for undefined variable in the code
Also we should update the usage in docs/usage/distrobox-create.md to reflect this change, and add also a couple of examples

Man pages are automatically generated from that change, so no need to recreate them yourself 👍

[juhp]

Ah yes thanks - hopefully better now and added more docs coverage.
I also added a corresponding --pull option.

[89luca89]

Thanks a lot for the contribution!

[juhp]

Thanks for your help too :-)