Skip to content

Commit

Permalink
[package] base-files: rewrite killing of nonessential services to not…
Browse files Browse the repository at this point in the history
… rely on top, use the proc filesystem only

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@29187 3c298f89-4303-0410-b956-a3cf2f4a3e73
  • Loading branch information
jow committed Nov 16, 2011
1 parent 27847c0 commit c76c2b2
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package/base-files/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk
include $(INCLUDE_DIR)/kernel.mk

PKG_NAME:=base-files
PKG_RELEASE:=94
PKG_RELEASE:=95

PKG_FILE_DEPENDS:=$(PLATFORM_DIR)/ $(GENERIC_PLATFORM_DIR)/base-files/
PKG_BUILD_DEPENDS:=opkg/host
Expand Down
26 changes: 17 additions & 9 deletions package/base-files/files/lib/upgrade/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,27 @@ run_ramfs() { # <command> [...]
kill_remaining() { # [ <signal> ]
local sig="${1:-TERM}"
echo -n "Sending $sig to remaining processes ... "
/bin/busybox top -bn1 2>/dev/null | while read pid ppid user stat vsz pvsz pcpu cmd args; do
case "$pid" in
[0-9]*) : ;;
*) continue ;;
esac
case "$cmd" in
# Skip kernel threads and essential services
\[*\]|*ash*|*init*|*watchdog*|*ssh*|*dropbear*|*telnet*|*login*|*ubusd*|*netifd*|*hostapd*|*wpa_supplicant*|*udhcpc*) : ;;

local stat
for stat in /proc/[0-9]*/stat; do
local pid name state ppid rest
read pid name state ppid rest < $stat
name="${name#(}"; name="${name%)}"

local cmdline
read cmdline < /proc/$pid/cmdline

# Skip kernel threads
[ -n "$cmdline" ] || continue

case "$name" in
# Skip essential services
*ash*|*init*|*watchdog*|*ssh*|*dropbear*|*telnet*|*login*|*ubusd*|*netifd*|*hostapd*|*wpa_supplicant*|*udhcpc*) : ;;

# Killable process
*)
if [ $pid -ne $$ ] && [ $ppid -ne $$ ]; then
echo -n "${cmd##*/} "
echo -n "$name "
kill -$sig $pid 2>/dev/null
fi
;;
Expand Down

0 comments on commit c76c2b2

Please sign in to comment.