Feat: Pubsub Datachannel #16
Conversation
|
@luongngocminh is attempting to deploy a commit to the 8xff Team on Vercel. A member of the Team first needs to authorize it. |
packages/sdk-core/src/data.ts
Outdated
| @@ -116,6 +121,109 @@ export class Datachannel extends EventEmitter { | |||
| } | |||
| } | |||
|
|
|||
| public async requestStartPublishChannel(req: { | |||
There was a problem hiding this comment.
We should leave all of details to msg_channel. I think in data.ts we only implement abstract like: requestMsgChannel
There was a problem hiding this comment.
Isn't data.ts purpose is to communicate to the server through implemented apis? msg_channel feature is depended on data.ts, so shouldn't the abstraction be on the msg_channel side? Developer should be able call data.ts in anyway they prefered without any abstraction.
There was a problem hiding this comment.
@luongngocminh No, data.ts is an abstraction for contacting servers. We don't need to update data.ts each time the protocol of Sender, Receiver, or MessageChannel ... changes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ) { | ||
| const ctx = useContext(Atm0sMediaContext); | ||
| const [channel, setChannel] = useState<RoomMessageChannel | null>(null); | ||
| useEffect(() => { |
There was a problem hiding this comment.
I think we need a function same with ctx.getOrCreatePublisher. Without it we will leak datachannel each time useEffect re-run
There was a problem hiding this comment.
instead of keeping a registry of msg channels in the react lib like the publishers, I've updated the core sdk to natively track the channels creation
There was a problem hiding this comment.
@luongngocminh It look good. Can you create same mechanism with publishers after this PR is merged?
There was a problem hiding this comment.
@giangndm do you want to move the publisher class into the core sdk? Because now it's only available in the react hooks side
Pubsub Datachannel implementation following this pr: 8xFF/atm0s-media-server#398
User can test the msg channel feature in the 2 of the
echo_fastexamples: