Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connector external event log - protobuf #132

Merged
merged 13 commits into from Jan 5, 2024

Conversation

luongngocminh
Copy link
Contributor

@luongngocminh luongngocminh commented Dec 27, 2023

Connector Server now accepts custom

  • http-port
  • node-id
  • message queue URI and channel which will provide support multiple protocol such as NATS, AMQP, MQTT, currently only Nats is supported
  • serializer type: JSON and Protobuf, currently only JSON is Implemented Protobuf only

Related to: #121

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (68a6f4f) 51.73% compared to head (62e068e) 52.78%.
Report is 1 commits behind head on master.

Files Patch % Lines
servers/media-server/src/server/connector.rs 0.00% 27 Missing ⚠️
...dia-server/src/server/connector/transports/nats.rs 0.00% 24 Missing ⚠️
...rs/media-server/src/server/gateway/webrtc_route.rs 0.00% 15 Missing ⚠️
packages/protocol/src/lib.rs 0.00% 11 Missing ⚠️
packages/endpoint/src/middleware/logger.rs 96.81% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   51.73%   52.78%   +1.04%     
==========================================
  Files         143      146       +3     
  Lines       11975    12171     +196     
==========================================
+ Hits         6195     6424     +229     
+ Misses       5780     5747      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm
Copy link
Contributor

@luongngocminh I have concern about how developer handle received event, which don't have type.

servers/media-server/Cargo.toml Show resolved Hide resolved
servers/media-server/src/server/connector.rs Outdated Show resolved Hide resolved
packages/cluster/Cargo.toml Outdated Show resolved Hide resolved
packages/cluster/src/define/rpc/connector.rs Outdated Show resolved Hide resolved
packages/cluster/src/define/endpoint.rs Outdated Show resolved Hide resolved
packages/protocol/Cargo.toml Show resolved Hide resolved
packages/protocol/src/media_endpoint_log.proto Outdated Show resolved Hide resolved
servers/media-server/src/server/connector.rs Outdated Show resolved Hide resolved
servers/media-server/src/server/connector.rs Show resolved Hide resolved
@luongngocminh luongngocminh changed the title feat: connector external event log - json feat: connector external event log - protobuf Jan 3, 2024
@luongngocminh luongngocminh mentioned this pull request Jan 4, 2024
33 tasks
Copy link
Contributor

@giangndm giangndm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix errors

@giangndm giangndm merged commit a8f74dd into 8xFF:master Jan 5, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
@github-actions github-actions bot mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants