Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/node info http endpoint #148

Closed

Conversation

luongngocminh
Copy link
Contributor

@luongngocminh luongngocminh commented Jan 5, 2024

Added /node-info API endpoint which will returns the following:
image

child of #132
fixes #147

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (68a6f4f) 51.73% compared to head (a290925) 52.67%.
Report is 1 commits behind head on master.

Files Patch % Lines
servers/media-server/src/server/connector.rs 0.00% 33 Missing ⚠️
...dia-server/src/server/connector/transports/nats.rs 0.00% 24 Missing ⚠️
...rs/media-server/src/server/gateway/webrtc_route.rs 0.00% 15 Missing ⚠️
packages/protocol/src/lib.rs 0.00% 11 Missing ⚠️
servers/media-server/src/server/gateway.rs 0.00% 6 Missing ⚠️
servers/media-server/src/server/rtmp.rs 0.00% 6 Missing ⚠️
servers/media-server/src/server/webrtc.rs 0.00% 6 Missing ⚠️
packages/endpoint/src/middleware/logger.rs 96.81% 5 Missing ⚠️
packages/cluster/src/implement/server.rs 25.00% 3 Missing ⚠️
packages/cluster/src/define/rpc/general.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   51.73%   52.67%   +0.94%     
==========================================
  Files         143      146       +3     
  Lines       11975    12199     +224     
==========================================
+ Hits         6195     6426     +231     
+ Misses       5780     5773       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm
Copy link
Contributor

giangndm commented Jan 5, 2024

@luongngocminh The field "service" seam to be confuse. In atm0s-sdn, a single node can be have several services, and above service maybe RPC service id?

@giangndm
Copy link
Contributor

giangndm commented Jan 5, 2024

@luongngocminh This PR include previous PR, please submit only releated commits

@luongngocminh
Copy link
Contributor Author

moved to #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to know a node's multiaddr after the initialization
2 participants