Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connector sending event to external consumer over NATS or Kafka #121

Closed
giangndm opened this issue Dec 20, 2023 · 7 comments
Closed
Assignees
Labels
help wanted Extra attention is needed

Comments

@giangndm
Copy link
Contributor

#120 PR only implemented core flow, for external using we need to implement external message queue producer

@Yosef0987
Copy link

NATS will be a good option

@giangndm
Copy link
Contributor Author

giangndm commented Dec 20, 2023

@Yosef0987 yeah, I think so. NATS is easier than Kafka to get started.

May be we can use protobuf instead of json for event serialize, which have better performance and bandwith save, an also easy to integrate will all other language like NodeJs or Golang

@giangndm giangndm added the help wanted Extra attention is needed label Dec 22, 2023
@luongngocminh luongngocminh self-assigned this Dec 22, 2023
@luongngocminh
Copy link
Contributor

@giangndm protobuf seems to be having a much higher overhead than JSON, for both safe typing and implementation, it's good to have, but I think JSON is enough for now?

@giangndm
Copy link
Contributor Author

@luongngocminh, I believe you're mistaken. Protobuf is a binary codec, making it faster and more efficient than JSON. You can find several benchmark tests online that show Protobuf's superior performance.

https://nilsmagnus.github.io/post/proto-json-sizes/
and https://www.codingexplorations.com/blog/performance-comparison-protobuf-marshaling-vs-json-marshaling-in-go

@luongngocminh
Copy link
Contributor

I know the benefits of using protobuf, but my point is that the implementation to convert the internal rust event enum to protobuf will have more boilercode, is it really matter that much or we can just provide it as an option later.

@giangndm
Copy link
Contributor Author

Ok, let do it in simplest way

@luongngocminh
Copy link
Contributor

luongngocminh commented Dec 27, 2023

@giangndm the connector pr is up: #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants