OrangePi i96 initial support #175
Conversation
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
| XSERVER ?= "xserver-xorg \ | ||
| mesa-driver-swrast \ | ||
| xf86-input-evdev \ | ||
| xf86-video-fbdev" |
There was a problem hiding this comment.
Can we change 'fbdev' to 'modesetting'?
There was a problem hiding this comment.
This thing is running with a v3.10 vendor kernel. I haven't checked explicitly (i96 not having easy access to video out) but I'd be surprised if it has a working KMS implemention.
|
|
||
| # TODO: Switch this to LS-UART1 and reduce to 115200 (921600 is needed | ||
| # on ttyS0 in order to match speeds with the boot ROM output | ||
| SERIAL_CONSOLE = "921600 ttyS0" |
There was a problem hiding this comment.
The SERIAL_CONSOLE variable is deprecated. Please use the SERIAL_CONSOLES variable. The format is slightly different, it isn't only a renaming of the variable.
| u-boot-orangepi-i96 \ | ||
| " | ||
|
|
||
| CMDLINE_ROOT_EMMC = "mmcblk0p2" |
There was a problem hiding this comment.
only 1 space: CMDLINE_ROOT_EMMC = "mmcblk0p2"
| @@ -0,0 +1,35 @@ | |||
| require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc | |||
|
|
|||
| FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:" | |||
There was a problem hiding this comment.
we don't apply any patches or ship extra files, so the line can be removed entirely.
|
|
||
| FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:" | ||
|
|
||
| SUMMARY = "U-Boot bootloader for OrangePi i96" |
There was a problem hiding this comment.
the file doesn't follow OE style guidelines. See u-boot-juno and u-boot-poplar that have been reformatted yesterday.
| SRCREV_kernel = "b476a2c5bfb893aba3ee4daa840196a97898bf48" | ||
| SRCREV_FORMAT = "kernel" | ||
|
|
||
| SRC_URI = "git://github.com/daniel-thompson/linux.git;nobranch=1;name=kernel" |
There was a problem hiding this comment.
can you add also protocol=https
| DEPENDS += "openssl-native" | ||
| HOST_EXTRACFLAGS += "-I${STAGING_INCDIR_NATIVE}" | ||
|
|
||
| #LDFLAGS += "${TOOLCHAIN_OPTIONS}" |
|
Thanks Fathi. Will make all the proposed changes. I'll try to get things updates in the next day or three. |
|
@parrotgeek1 : Acting on the review comments is still on my TODO list but has got pretty deeply buried by other things. It will be a while longer before I can repost. |
|
@daniel-thompson based on the minor fixes that has been pointed at the review. we/I can take it from there and make the fixes myself before merging. |
|
@fboudra : A generous offer if you have the time... (I've just replied to Koen's comment about fbdev since I think that needs more then OE knowhow to conclude on). |
|
@parrotgeek1: However, it doesn't look like I'll get round to that anytime soon so perhaps I should regenerate everything from a linaro-android baseline instead. |
Initial support is based on the vendor kernel and u-boot.
The vendor code currently has minimal changes, however they are modified to support gcc-7.