exec: report cmd.Run() error; e.g. command not found. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture and pass the error from `cmd.Run()` to `ui.Error.Fatal()` so that failed commands are reported and exit with a non-zero status. Before: ``` $ aws-vault exec 99designs true ; echo $? 0 $ aws-vault exec 99designs false ; echo $? 0 $ aws-vault exec 99designs blargh ; echo $? 0 ``` After: ``` $ aws-vault exec 99designs true ; echo $? 0 $ aws-vault exec 99designs false ; echo $? exit status 1 1 $ aws-vault exec 99designs blargh ; echo $? exec: "blargh": executable file not found in $PATH 1 ```
lox
added a commit
that referenced
this pull request
Oct 6, 2015
exec: report cmd.Run() error; e.g. command not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture and pass the error from
cmd.Run()toui.Error.Fatal()so that failed commands are reported and exit with a non-zero status.Before:
After:
This needs fine-tuning so that the second case silently passes through the exit status, while the third case still reports that the command wasn't found. But for now this fixes the much bigger problem of failing to propagate errors at all.