Handle OIDC caching for new keyring entries #631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing the new OIDC caching in #628 (yay!) and ran into some errors when I had no existing OIDC entry in my keychain.
First, aws-vault would die immediately with:
After a tweak to fix that, it would go through most of the normal credential flow but die later:
After erroring out once, I would see the OIDC entry in my keychain and subsequent runs would work as expected.
This PR is a first pass attempt to address both first-run errors. Happy to talk through it or make additional changes as needed.