Close Websocket Connection on Context close/cancel

[RobinCPel]

This issue explains it all: #1727

I have:

• Added tests covering the bug / feature (see testing)

Not needed:

• Updated any relevant documentation (see docs)

[coveralls]

Coverage increased (+0.1%) to 70.451% when pulling f74739b on RobinCPel:ws-ctx-done-close into 4581fcc on 99designs:master.

[StevenACoffman]

Suggested change

	h := testserver.New()
	h.AddTransport(transport.Websocket{
	InitFunc: func(ctx context.Context, _ transport.InitPayload) (context.Context, error) {
	newCtx, _ := context.WithTimeout(transport.AppendCloseReason(ctx, "beep boop"), time.Millisecond*5)
	return newCtx, nil
	},
	})
	srv := httptest.NewServer(h)
	defer srv.Close()
	h := testserver.New()
	var cancel context.CancelFunc
	h.AddTransport(transport.Websocket{
	InitFunc: func(ctx context.Context, _ transport.InitPayload) (context.Context, error) {
	var newCtx context.Context
	newCtx, cancel = context.WithTimeout(transport.AppendCloseReason(ctx, "beep boop"), time.Millisecond*5)
	return newCtx, nil
	},
	})
	defer cancel()
	srv := httptest.NewServer(h)
	defer srv.Close()

I know it's just for a test, but what do you think about retaining the closeFunc and calling it in a defer somewhere to satisfy the linter that there's no leaks?

[StevenACoffman]

Thanks! I hope you don't mind, but I ran gofmt and pushed that change to your remote branch. The linter is still complaining about the possible context leak, and I provided a suggestion for your consideration. Overall, this looks pretty good to me. @zdraganov do you have any thoughts?

[zdraganov]

LGTM

[StevenACoffman]

Thanks so much!

[RobinCPel]

And thank you for the quick support! ;)