Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate field defenition and execute field directive #756

Merged
merged 6 commits into from
Jun 26, 2019
Merged

generate field defenition and execute field directive #756

merged 6 commits into from
Jun 26, 2019

Conversation

andrey1s
Copy link
Contributor

  • add execute FIELD directive
  • add generate FIELD_DEFINITION to resolve field
  • use unmarshal by type argument definitions directives FIELD_DEFINITION, INPUT_FIELD_DEFINITION and ARGUMENT_DEFINITION
  • move fieldMiddleware to directives tpl
  • put obj as input value to directives by type
    • args - all map args
    • input field - input objext
    • object field - object

@vektah
Copy link
Collaborator

vektah commented Jun 24, 2019

This pr is a bit to big, I can't really follow what's changed. A couple of commits to split the modifications from the moves would help a bunch.

@andrey1s
Copy link
Contributor Author

divided into several commits

@vektah
Copy link
Collaborator

vektah commented Jun 26, 2019

Cool! getting close to full execution directive support now.

@vektah vektah merged commit 5e7e94c into 99designs:master Jun 26, 2019
@vektah vektah added the v0.9.1 fixed in v0.9.1 label Jun 27, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
generate field defenition and execute field directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.9.1 fixed in v0.9.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants