Add cgo build tag for crosscompiles #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-keychain is all cgo as of right now, so attempting to cross-compile a darwin executable of aws-vault on linux results in errors about undefined functions. If the cgo build tag is added here, linux cross-compiles of darwin complete successfully (albeit without keychain functionality). I am interested in this because I want transparent access across a host macbook and multiple vagrant machines running on it with the .aws-vault directory mapped into them, which seemed to work after I compiled binaries including this change.
|
@lox what do you think here? |
|
Sorry for the slow response. I'll need to look into it some more, I'm not sure I quite understand the usecase for darwin builds without keychain support, I wonder if there is a better way to accomplish that. |
|
Is there a reason explicitly not to support it? Current running |
|
Would this change how we compile and build normally on darwin? If not, I'm happy to merge. |
|
Fixes #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-keychain is all cgo as of right now, so attempting to cross-compile a darwin executable of aws-vault on linux results in errors about undefined functions. If the cgo build tag is added here, linux cross-compiles of darwin complete successfully (albeit without keychain functionality). I am interested in this because I want transparent access across a host macbook and multiple vagrant machines running on it with the .aws-vault directory mapped into them, which seemed to work after I compiled binaries including this change.