Fix undo/redo with autoindent enabled. #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserting a \n should commit the text, causing a following undo to backup to the \n, but not before it. However, there was a bug when autoindent was enabled that caused \n to not commit the text in most cases, allowing undo to undo beyond the \n. Specifically in texttype, the variable r is the typed character. At the bottom of the function, if r == '\n', then it commits the text. But when autoindent was enabled, r was overwritten by the loop looking for the first non-space character of the preceeding line. Then the r == `\n` check was hit, r is the first non-space rune on the preceeding line, not the typed `\n`, and so no commit is made.
martijn-heil
pushed a commit
to martijn-heil/9front
that referenced
this pull request
Aug 29, 2021
rdbyk
pushed a commit
to rdbyk/9front
that referenced
this pull request
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting a \n should commit the text, causing a following undo to backup to the \n, but not before it. However, there was a bug when autoindent was enabled that caused \n to not commit the text in most cases, allowing undo to undo beyond the \n.
Specifically in texttype, the variable r is the typed character. At the bottom of the function, if r == '\n', then it commits the text. But when autoindent was enabled, r was overwritten by the loop looking for the first non-space character of the preceeding line. Then the r ==
\ncheck was hit, r is the first non-space rune on the preceeding line, not the typed\n, and so no commit is made.