Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "enum34" requirement in setup.py. #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Freso
Copy link

@Freso Freso commented Jan 10, 2017

The enum module is not actually imported in any part of the codebase and "enum34" isn't relevant for Python version 3.4 and later even if it was relevant. (Current Python is 3.6.x.)

freso@koume /t/f/concierge (master)> git grep -i enum|cat
concierge/core/lexer.py:    for index, line in enumerate(lines, start=1):
setup.py:    "enum34"

The `enum` module is not actually imported in any part of the codebase
and "enum34" isn't relevant for Python version 3.4 and later even if it
was relevant. (Current Python is 3.6.x.)
@Freso
Copy link
Author

Freso commented Jan 10, 2017

Tests for Python 3.3 and 3.4 are failing because some of the dependencies for testing require Python ≥ 3.5…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant