Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build #213

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Fix windows build #213

merged 2 commits into from
Oct 4, 2021

Conversation

9seconds
Copy link
Owner

@9seconds 9seconds commented Oct 4, 2021

This PR resembles #209 I'm not sure why it is stale and CI does not give a green light.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #213 (d1e5f9d) into master (706aef8) will decrease coverage by 0.18%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   84.18%   84.00%   -0.19%     
==========================================
  Files          67       68       +1     
  Lines        1859     1863       +4     
==========================================
  Hits         1565     1565              
- Misses        206      210       +4     
  Partials       88       88              
Impacted Files Coverage Δ
network/sockopts.go 18.18% <0.00%> (-6.82%) ⬇️
network/sockopts_unix.go 50.00% <50.00%> (ø)
network/circuit_breaker.go 76.92% <0.00%> (-7.70%) ⬇️
mtglib/internal/relay/relay.go 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706aef8...d1e5f9d. Read the comment docs.

@9seconds
Copy link
Owner Author

9seconds commented Oct 4, 2021

This also fixes #212

@9seconds 9seconds merged commit 01b739a into master Oct 4, 2021
@9seconds 9seconds deleted the fix-windows-build branch October 4, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants