add functionality use_mocks_only #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
LGTM 👍 @tbranyen could you take a look on it? |
tbranyen
reviewed
Jan 25, 2017
| }, /Unmocked url/); | ||
| done(); | ||
|
|
||
| mock.disableUseMocksOnly(); |
There was a problem hiding this comment.
Shouldn't the clean up code happen before we call done()? My assumption was that once done() was called, the next test starts running.
|
Looks good to me, just left a comment about the clean up code. |
|
So we are just waiting for a fix from @risentveber ?? |
|
Looks like it, I'm a bit hesitant to merge in something that could break tests down the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add use mocks only functionality. When it is enabled and there is no such route it throws error.