Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI #20

Closed
wants to merge 2 commits into from
Closed

Add CLI #20

wants to merge 2 commits into from

Conversation

denysdovhan
Copy link
Contributor

I've removed test/bench.js and add CLI decs into readme.md. Please, check and merge if all right.

[cli]: https://github.com/denysdovhan/textr-cli
[examples]: https://github.com/denysdovhan/textr-cli#usage
[options]: https://github.com/denysdovhan/textr-cli#options

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli documention here will become outdated pretty fast, so maybe better just have this section ## CLI \n\n\n Also, there is a [CLI package][cli] for running Textr under your terminal.. what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think base flags will stand unchanged in future, so we can keep it readme. Of course, will be new features but for this case there is line:

Take a look for more usage examples and CLI options.

@A
Copy link
Owner

A commented Nov 13, 2015

I see 2 different ways: 1) Move CLI to the core textr module that approach will resolve problem w/ outdated docs 2) put link to the CLI into the head part of the docs. So, what you yourself take, what you'll give to your collaborators? :D

image

@A
Copy link
Owner

A commented Nov 13, 2015

@denysdovhan Oh, if you take first one, I'll give access to this repo for you, of course.

@A
Copy link
Owner

A commented Nov 13, 2015

@iamstarkov what you think about my idea?

@iamstarkov
Copy link
Collaborator

@shuvalov-anton i dont like idea of having cli and tool itself in one repo and in one package

@A
Copy link
Owner

A commented Nov 13, 2015

But it highly coupled to the another one.

@A
Copy link
Owner

A commented Nov 13, 2015

@iamstarkov anyway we have second point

@denysdovhan
Copy link
Contributor Author

i dont like idea of having cli and tool itself in one repo and in one package

I don't like too, bcoz would be better to keep textr core w/o deps.

@A
Copy link
Owner

A commented Nov 14, 2015

Ok, if so, just take second one. @denysdovhan can you add just link and few words about CLI to the top of the readme file?

@A
Copy link
Owner

A commented Nov 14, 2015

@iamstarkov @denysdovhan please decide what we should have in the readme file. I've checked current pr just now, and it looks ok to me. I hope that the basic examples should be constant in the long term. So I'm ok to merge it.

@denysdovhan
Copy link
Contributor Author

can you add just link and few words about CLI to the top of the readme file?

What do you mean? Move my changes to the top or what?

@A A closed this Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants