-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI #20
Add CLI #20
Conversation
[cli]: https://github.com/denysdovhan/textr-cli | ||
[examples]: https://github.com/denysdovhan/textr-cli#usage | ||
[options]: https://github.com/denysdovhan/textr-cli#options | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cli documention here will become outdated pretty fast, so maybe better just have this section ## CLI \n\n\n Also, there is a [CLI package][cli] for running Textr under your terminal.
. what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think base flags will stand unchanged in future, so we can keep it readme. Of course, will be new features but for this case there is line:
Take a look for more usage examples and CLI options.
@denysdovhan Oh, if you take first one, I'll give access to this repo for you, of course. |
@iamstarkov what you think about my idea? |
@shuvalov-anton i dont like idea of having cli and tool itself in one repo and in one package |
But it highly coupled to the another one. |
@iamstarkov anyway we have second point |
I don't like too, bcoz would be better to keep textr core w/o deps. |
Ok, if so, just take second one. @denysdovhan can you add just link and few words about CLI to the top of the readme file? |
@iamstarkov @denysdovhan please decide what we should have in the readme file. I've checked current pr just now, and it looks ok to me. I hope that the basic examples should be constant in the long term. So I'm ok to merge it. |
What do you mean? Move my changes to the top or what? |
I've removed
test/bench.js
and add CLI decs intoreadme.md
. Please, check and merge if all right.