Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#360: fixed VStar.app deletion; improved mac target while there #361

Merged
merged 2 commits into from
Jul 8, 2023
Merged

#360: fixed VStar.app deletion; improved mac target while there #361

merged 2 commits into from
Jul 8, 2023

Conversation

dbenn
Copy link
Collaborator

@dbenn dbenn commented Jul 7, 2023

Please check this no longer fails on Windows @mpyat2. Works on Mac.

@dbenn dbenn added the bug Something isn't working label Jul 7, 2023
@dbenn dbenn requested a review from mpyat2 July 7, 2023 08:04
@dbenn dbenn self-assigned this Jul 7, 2023
@dbenn dbenn linked an issue Jul 7, 2023 that may be closed by this pull request
ant clean target fails on Windows #360
Closed
mpyat2
mpyat2 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@mpyat2 mpyat2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dbenn ! Now ant clean runs smoothly under Windows!

@dbenn dbenn merged commit d67d52b into master Jul 8, 2023
24 checks passed
@dbenn dbenn deleted the 360-ant-clean-target-fails-on-windows branch July 8, 2023 13:07
@mpyat2 mpyat2 mentioned this pull request Jul 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpyat2 mpyat2 mpyat2 approved these changes

Assignees

@dbenn dbenn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ant clean target fails on Windows
2 participants
@dbenn @mpyat2