Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies #96

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Remove dependencies #96

merged 1 commit into from
Dec 24, 2021

Conversation

bdovaz
Copy link
Contributor

@bdovaz bdovaz commented Dec 24, 2021

Remove unnecessary System.Runtime.InteropServices dependency.

@codecov-commenter
Copy link

Codecov Report

Merging #96 (6141a54) into master (95eff87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files           9        9           
  Lines         292      292           
=======================================
  Hits          267      267           
  Misses         25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95eff87...6141a54. Read the comment docs.

@AArnott AArnott merged commit 4bcbb5d into AArnott:master Dec 24, 2021
@bdovaz bdovaz deleted the remove-dependencies branch December 24, 2021 16:54
@bdovaz
Copy link
Contributor Author

bdovaz commented Dec 24, 2021

@AArnott can you release a new NuGet package version without this dependency? Thanks.

@AArnott
Copy link
Owner

AArnott commented Dec 24, 2021

How is this blocking you?

@bdovaz
Copy link
Contributor Author

bdovaz commented Dec 24, 2021

Yes because we use it with Unity and it only supports .NET Standard 2.0 / 2.1 packages.

We use it with:

https://github.com/xoofx/UnityNuGet

@AArnott
Copy link
Owner

AArnott commented Dec 25, 2021

Ok. 2.6.13-beta is on its way to nuget.org now.

@bdovaz
Copy link
Contributor Author

bdovaz commented Dec 25, 2021

Thanks, but that UnityNuGet library only works with stable versions...

@AArnott
Copy link
Owner

AArnott commented Dec 25, 2021

Then you'll need to send a PR to our latest stable branch instead of our main development branch.

@bdovaz
Copy link
Contributor Author

bdovaz commented Dec 28, 2021

@AArnott what's branch is it?

https://github.com/AArnott/Validation/branches/all

Thanks!

@AArnott
Copy link
Owner

AArnott commented Dec 28, 2021

Oh, gosh. I guess in this repo I don't have a stable branch for v2.5. Let me get back to you on that.

@AArnott
Copy link
Owner

AArnott commented Dec 29, 2021

Ok. I've pushed a v2.5 branch and cherry-picked your change to it. We'll get a stable 2.5 release out to nuget.org today.

AArnott pushed a commit that referenced this pull request May 2, 2023
Bumps [Microsoft.Net.Compilers.Toolset](https://github.com/dotnet/roslyn) from 3.9.0-3.final to 3.9.0.
- [Release notes](https://github.com/dotnet/roslyn/releases)
- [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md)
- [Commits](https://github.com/dotnet/roslyn/commits/v3.9.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants