Dynamically fetch whole body scaffold url for human. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran it and it works well! Was wondering how does it decide whether to go horizontal or vertical split?
I thought vertical split could be better here but I think it works very well as is ( I also took this screenshot on quite a wide screen) |
Tehsurfer
approved these changes
Mar 31, 2023
| } else { | ||
| //Use default url if data is not found for any reason | ||
| if (species === "rat") { | ||
| return "https://mapcore-bucket1.s3.us-west-2.amazonaws.com/WholeBody/31-May-2021/ratBody/ratBody_syncmap_metadata.json"; |
There was a problem hiding this comment.
The other species can't make a request for a whole body scaffold right?
There was a problem hiding this comment.
No, we have decided to do that for rat and human. The rat dataset does not work well ( facing the opposite directly) so it is a hardcoded path for now.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch whole body scaffold information then use it for sync map, it only works for human at this moment.
This can be tested with this branch and set
VUE_APP_API_LOCATION=https://alan-wu-portal-api.herokuapp.com/.Or watch the following video preview.
Physiome.Portal.-.2023-03-30.15-02-45.mp4