Add featured marker to legend, show if we have a featured marker #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tehsurfer
changed the title
alan-wu
reviewed
Nov 30, 2023
| @@ -270,7 +272,13 @@ export default { | |||
| const markerIdentifier = | |||
| store.state.settings.featuredMarkerIdentifiers[index]; | |||
| if (!markerIdentifier) { | |||
| this.addFeaturedMarker(markers[index], index, flatmap); | |||
| let markerExists = this.addFeaturedMarker(markers[index], index, flatmap); | |||
There was a problem hiding this comment.
We want to set showStarInLegend to true as long as there is a valid marker. The current implementation will fail if the first few markers are valid and the last one is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the props from ABI-Software/flatmapvuer#122 to turn on the featured marker in legend if we have a featured marker and off if not