Rating uploadify latest #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llis_install() class extends the trellis() class but their load_email() and load_antispam() methods don't accept parameters of the same type. Error on the screen is: Strict Standards: Declaration of trellis_install::load_email() should be compatible with that of trellis::load_email() in var/www/trellis-desk-2/install/trellis_install.php on line 207 Strict Standards: Declaration of trellis_install::load_antispam() should be compatible with that of trellis::load_antispam() in /var/www/trellis-desk-2/install/trellis_install.php on line 207 These methods in the main trellis class accept an optional boolean "test" value, and in the trellis_install class they accept an array of values. I propose renaming these methods in the trellis_install class to load_email_from_array() and load_antispam_from_array(). In this file (install/index.php), I have updated the code to call these methods by their newly proposed names.
…llis_install() class extends the trellis() class but their load_email() and load_antispam() methods don't accept parameters of the same type. Error on the screen is: Strict Standards: Declaration of trellis_install::load_email() should be compatible with that of trellis::load_email() in var/www/trellis-desk-2/install/trellis_install.php on line 207 Strict Standards: Declaration of trellis_install::load_antispam() should be compatible with that of trellis::load_antispam() in /var/www/trellis-desk-2/install/trellis_install.php on line 207 These methods in the main trellis class accept an optional boolean "test" value, and in the trellis_install class they accept an array of values. I propose renaming these methods in the trellis_install class to load_email_from_array() and load_antispam_from_array(). In this file (install/trellis_install.php), I have renamed these methods to their newly proposed names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rating is not fully implemented, its currently a hard coded image. Should be the script in the future.