Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prodigal Banderling #1675

Merged

Conversation

TectonicRifts
Copy link
Collaborator

Corrects Harraag's appearance (an incorrect setup was used).
Corrects adds in the last room from Loud Lou retail video and deletes unnecessary generator.
Sets respawn to 5 min (timed from video). Previously, was 10 min.
Adds missing Banderling NPCs to outdoor landblocks (4 from pcap, 2 from vlocs, also seen in the video).
Adds missing proc spell rate to the dagger reward.
Revises the stats on Haraag's weapon based on the wiki (adds missing proc spell rate, lightning cleaving). Also adjusts Harraag's skills to account for large melee, missile and magic defense bonuses on the weapon.

TectonicRifts and others added 2 commits May 31, 2024 13:58
Corrects Harraag's appearance (an incorrect setup was used).
Corrects adds in the last room from Loud Lou retail video and deletes unnecessary generator.
Sets respawn to 5 min (timed from video). Previously, was 10 min.
Adds missing Banderling NPCs to outdoor landblocks (4 from pcap, 2 from vlocs, also seen in the video).
Adds missing proc spell rate to the dagger reward.
Revises the stats on Haraag's weapon based on the wiki (adds missing proc spell rate, lightning cleaving). Also adjusts Harraag's skills to account for large melee, missile and magic defense bonuses on the weapon.
@LtRipley36706 LtRipley36706 changed the base branch from master to v0.9.281 June 24, 2024 17:13
@LtRipley36706 LtRipley36706 merged commit a0338b7 into ACEmulator:v0.9.281 Jun 24, 2024
1 check passed
LtRipley36706 added a commit that referenced this pull request Jul 15, 2024
* Update Swift Set (#1672)

* Update 04816 Novice Soldier's Finesse Weapon Aptitude.sql

Update from Dagger to Finesse Weapons

* Update 04817 Apprentice Soldier's Finesse Weapon Aptitude.sql

* Update 04818 Journeyman Soldier's Finesse Weapon Aptitude.sql

* Update 04819 Master Soldier's Finesse Weapon Aptitude.sql

* Update KillTaskSpectralClawsBlades0812.sql (#1673)

Update kill task count to match contract

* Update Prodigal Banderling (#1675)

* Update Prodigal Banderling

Corrects Harraag's appearance (an incorrect setup was used).
Corrects adds in the last room from Loud Lou retail video and deletes unnecessary generator.
Sets respawn to 5 min (timed from video). Previously, was 10 min.
Adds missing Banderling NPCs to outdoor landblocks (4 from pcap, 2 from vlocs, also seen in the video).
Adds missing proc spell rate to the dagger reward.
Revises the stats on Haraag's weapon based on the wiki (adds missing proc spell rate, lightning cleaving). Also adjusts Harraag's skills to account for large melee, missile and magic defense bonuses on the weapon.

* Update 87339 Harraag's Lair.sql

---------

Co-authored-by: Ty Conner <tyconner@itcproductions.com>

* Update Vissidal Undead (#1677)

Corrects scale, and sets skills and armor level from pcaps. Revises spellbook based on some retail screenshots.

* Update 72510 Materialized Hoshino Kei.sql (#1678)

Swaps motion table to make her float when she moves, as seen in retail video by Immortal Bob.

* Update Sanamar Collector (#1679)

Now takes 31349 yellow armband from Mosswart Elder as per bug report from justindz.

* Update Bur (#1681)

* Update Bur

Revises Southern Catacombs spawns for a closer match to retail (as seen in Berek retail video). Also reduces mushroom spawn rate which was excessive. In the pcap, mushrooms make up 6-7% of the spawns. Currently, more than half of spawns appear to be mushrooms.
Cleans up duplicate Baby Thrungus in Kor Gursha and adds emote so they roam around (as seen in Tzepesh retail video).

* Update 00D4.sql

Added missing exit portals from vlocs, and filled in some sections that were left empty.

* Update Northern Caverns

Same treatment for the Northern Caverns.
Adds missing descriptions to decorative house items sold on Bur.

* update eastern catacombs

Same treatment for Eastern Catacombs.

* Add Jungle Orchid Quest (#1682)

* Add Jungle Orchid Quest

Adds the quest:

http://acpedia.org/wiki/Jungle_Orchid

* correct typo

Corrected a typo not found in the npc speech pcap.

* Update Rynthid Outdoors (#1684)

* Update Rynthid Outdoors

Adjusts skills on rynthid to match the pcap skill estimates. In general, magic was too high, and in some cases melee and missile were too low.
Revises outdoor generators for a better match to retail based on Loud Lou video. From the video, I estimated respawn to be longer than 5 min but less than 10, so set to 7 min.
Fixes Rynthid Crystal so it will generate adds.

* ring spell and drop table

Changes version of heavy lightning ring cast by some Rynthid to a lower damage version. The higher damage version, which can do close to 500 damage per hit, was used by mistake.
Corrects drop table for Aspect of Rage and Torment, so each cloak has an independent 5% chance of dropping.

* update indoor rynthid

Same treatment for dungeon rynthid.

* Update Paradox Olthoi (#1685)

Sets skills and armor values from the pcap, and revises resistance mods to match existing olthoi.
Corrects scale of Ward Guardian, and a few other olthoi.
Corrects body table of Sentinel type olthoi, which were previously doing 0 damage with one of their body part.
Adds missing idle emote to some olthoi.

* Fix Prodigal Lugian (#1686)

Corrects a number of issues with the Prodigal Lugian quest reported by players. In retail, multiple people could do this quest without interfering with each other. As is, the quest only works properly for one person at a time, and can cause others to get stuck for over 30 min due to unnecessary use of events and landblock keep alives.

This redesigns the quest, allowing multiple people to work on the trials at the same time (such as in the Burun Kings quest where a similar mechanic is used).

Also resolves console errors - missing combat table on a boulder, and failing to spawn weenie, which had not been included.
Corrects energy cage mechanic, and scene at the end of one trial.
Corrects final fight. As seen in the pcap, adds are clearly spawned by Kresovus around him, thus removing multiple unnecessary wave gens.
Adds missing emote to boulder in Trial of the Arm, which in retail, could be "moved" if the person had a high enough base strength (thus, the name of the trial). This is why this boulder is useable in the pcap. If strength was not high enough, it could alternatively be killed.
Fixes a bug where the Trial of the Mind was purely cosmetic (i.e., did not stamp the player correctly). The player could previously move on without doing the trial at all.
Cleans up duplicate spawns in the fur room.
Adds NPC looks like object to Altar.

* Update Spear of the Given Heart Quest (#1687)

* Update Spear of the Given Heart Quest

Updates this quest to the end of retail spawns and XP reward.

https://asheron.fandom.com/wiki/Spear_of_the_Given_Heart_Quest

* Update 23345 Iron Golem Guardian.sql

Update XP.

* Update Crystal Minds Quest (#1688)

Updates this quest to end of retail spawns.

http://acpedia.org/wiki/Crystal_Minds_and_Shattered_Souls

* Add Bloodstone to Frozen Valley (#1690)

* Add Bloodstone to Frozen Valley

Adds 43743 Bloodstone to the FV generator as per pcap.

https://asheron.fandom.com/wiki/Bloodstone_(Creature)

Also adjusts spawn rate of Frozen Dread - the pcap suggests they were about 7% of the total spawns, similar to other single mob spawns in this generator. The Bloodstone now takes its place as the rare mob (just over 1% chance).

Revises name of SnowTuskers240 generator. This is actually a Gurog Camp generator. Also adds additional Gurog Minion as seen in a retail video by Kala Glow.

* Update 43743 Bloodstone.sql

Sets melee damage to typeless as per wiki.

* Update 03534 Free Ride to the K'nath Lair.sql

* normalize

* Create 87340 Harraag's Hideout Banderling Gen.sql

* normalize

* 40250, 40485, 71390 Fixed 'detected bad quaternion' errors in server log (#1674)

* 40250, 40485, 71390 Fixed 'detected bad quaternion' errors in server log

Nudges these three portal destinations to remove error messages from server log.
[37] WARN  (ACE.Server.Entity.PositionExtensions) detected bad quaternion x y z w for Entrance to the pyramid (0x773C8002) | WCID: 40250 | WeenieType: Portal | PositionType: Destination
[37] WARN  (ACE.Server.Entity.PositionExtensions) before fix: 0x00CB0100 [0.000000 0.000000 -29.995001] 0.020795 0.000000 0.000000 -1.000000
[37] WARN  (ACE.Server.Entity.PositionExtensions)  after fix: 0x00CB0100 [0.000000 0.000000 -29.995001] 0.020791 0.000000 0.000000 -0.999784

[26] WARN  (ACE.Server.Entity.PositionExtensions) detected bad quaternion x y z w for Crystalline Portal (0x788031B8) | WCID: 40485 | WeenieType: Portal | PositionType: Destination
[26] WARN  (ACE.Server.Entity.PositionExtensions) before fix: 0x870401F6 [120.050003 -134.690002 -155.990005] -0.005000 0.000000 0.000000 0.990000
[26] WARN  (ACE.Server.Entity.PositionExtensions)  after fix: 0x870401F6 [120.050003 -134.690002 -155.990005] -0.005050 0.000000 0.000000 0.999987

[7] WARN  (ACE.Server.Entity.PositionExtensions) detected bad quaternion x y z w for Catacombs (0x7575414C) | WCID: 71390 | WeenieType: Portal | PositionType: Destination
[7] WARN  (ACE.Server.Entity.PositionExtensions) before fix: 0x57540264 [99.951202 -2.459900 0.006000] 0.042400 0.000000 0.000000 0.990000
[7] WARN  (ACE.Server.Entity.PositionExtensions)  after fix: 0x57540264 [99.951202 -2.459900 0.006000] 0.042789 0.000000 0.000000 0.999084

* 40250 40485 71390 Fixed quaternion issue with 0.0.0.1 as recommended.

40250 40485 71390 Fixed quaternion issue with these 3 portals
by setting w,x,y,z as 0.0.0.1 as recommended in review comments.

* Update Gurog Creation (#1692)

Minor updates and bug fixes to this quest based on retail videos by Kala Glow and Geffers58.

The Journal of a Soldier can now be read.
The Mortified Soldier is now in a ShiverState as seen in the video.
Set location of two doors from vlocs (these were not papped, and were previously manually placed).
Adjusted some spawns in non-pcapped sections of the dungeon to match the video.
Respawn increased to 5 min (was previously 3 min). The video shows it was longer than 3 min.

* Add Prismatic Amuli and Celdon Recipes (#1693)

* Add Prismatic Amuli and Celdon Recipes

Adds recipes to create these Shadow Armor pieces. Although retired, they could still be made at the end of retail if a person had left over armor pieces, and could be useful for server operators who wish to make this armor available again.

* no longer consume glyph

Only one glyph is required as per wiki description.

* Update Health Draining Rats (#1694)

Adds missing spells based on the wiki description, and skills, armor levels from pcap. Also corrects combat table so the Infectious Rat will use its breath attack.

* Update Gearknight Invasion (#1695)

Updates inner sea and direlands invasion areas to remove unnecessary events (total of 9), and corrects portal mechanic to match retail based on video by Ultimis (EP47). Also updates stockpile to remove unnecessary events, and correct motion table on the stockpiles so they do not "bounce" when they die. Adds missing on death broadcast seen in the video.

Gearknight Guardians, Lesser Lords, and corresponding portals now on wave gens. This removes a total of 7 events. In the video, the Lesser Lords do not summon a gateway. Rather, a portal spawns 10 seconds after they die. The portals have special artwork, and are not white gateways.

* Update Shadow Aspect of Grael (#1696)

Adds missing spawns to outdoor landblocks with the Shadow and  Ruschk temple portals (F41F and 5BDB).
Adjusts dungeon spawn locations in the Shadow temple (no pcap) to match the pcapped Mukkir temple locations (the two dungeons are copies).
Adds spawn traps mentioned on the wiki, like in the Mukkir version.
Replaces custom wcid Grael's Chamber shortcut portal with the pcapped wcid. This is also found outside in the Shadow March area (landblock 2893) where it is now added.
Adjusts spells for Shadow Aspect of Grael, and increases his melee damage.

* Misc Updates July (#1697)

* Misc Updates July

Updates clothing (mostly missing cloaks) of some Gearknight Direlands Invasion area NPCs, and setup of Iron Blade Warmaster, to match their appearance on a Loud Lou retail video.
Adds missing clothing base and palette to Aun Oltra at Rynthid Infested Plains Camp.
Escaped Thief in Sword of Belenesse quest now has friend type Eater, so his eaters will come to his aid when attacked from a distance, like in retail. Removes flamma and flare spawns in the Sword of Belenesse dungeon. All of these spawn from the Infernos and should not be in the linkable monster gen.
Adds missing attuned, bonded, and description to Underminer Notes from Shield of Yanshi quest, and changes respawn to 5 min. This had been left with the default pcap gen (of about 13 min). The respawn was not that slow.

* Update 33542 Lanaith.sql

Updates appearance of Lanaith to match retail video by ImmortalBob (and wiki screenshots).

* Update Crystalline Crag (#1676)

Revises outdoor and dungeons based on pcaps and a Tzepesh retail video:
Sets mob skills from the pcap. In general, magic and magic defense were too high, while melee attack and defense were too low.
Corrects spell books from pcap and video and adjusts create list.
Adjusts outdoor spawns to match retail video.
Adds missing flavor text to crystals that spawn wisps.
Cleans up dungeon landblocks to remove duplicate mobs and fills in some empty sections.

* normalize

* Update 41583 Copper Cog Lesser Lord.sql

* Update 70351 Mortified Soldier.sql

* Update 70351.es

* Create 70351.sql

* Create 40146 Crystalline Resin.sql

* Create 80050 Crystal Gen.sql

* Update 00C7.sql

* Update 80050 Crystal Gen.sql

* normalize

* Update 00C7.sql

* normalize

* Add Undead Attack and Zombie Butler Quest (#1680)

Adds the seasonal quests below tied to EventFallFestival:

https://asheron.fandom.com/wiki/Undead_Attack_on_Al-Jalima?so=search

https://asheron.fandom.com/wiki/Zombie_Butler_Quest

* Fix Olthoi Sentinel Tracker LW/MeD values based off PCAP estimates (#1698)

* normalize

* finalize

---------

Co-authored-by: Nalindar <nalindargit@gmail.com>
Co-authored-by: OptimShi <OptimShi@users.noreply.github.com>
Co-authored-by: TectonicRifts <60861066+TectonicRifts@users.noreply.github.com>
Co-authored-by: lugielord <156704507+lugielord@users.noreply.github.com>
Co-authored-by: Boop-AC <90673082+Boop-AC@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants