Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Pick up not checking bound quest #1198

Closed
ghost opened this issue Dec 30, 2018 · 2 comments
Closed

Item Pick up not checking bound quest #1198

ghost opened this issue Dec 30, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 30, 2018

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [X] feature request

Repro steps.

Repeated pick-ups of items that should be quest bound is still allowed

Desired functionality.

Item pickup functions should be checking for linked quest status via weenie_properties_string 33.

Mention any other details that might be useful.

@gmriggs
Copy link
Collaborator

gmriggs commented Dec 30, 2018

Hey Jyrus,

I am checking out this issue on the latest version of master branch, and also the inventory PR that magnus is working on (#1197)

I am running /create stoneshiveringmajor to spawn a Major Shivering Stone, picking up (success the first time), and then creating another one

When I try to pick up the second one, I get the the werror, and the quest timer message:

You have solved this quest too recently!
You may complete this quest again in 59m 54s.

Can you provide any additional repro steps / particular items / quests where you are seeing this bug?

Thank you

@ghost
Copy link
Author

ghost commented Jan 1, 2019

In testing master, this functionality is now present. I had been meaning to file this issue for awhile but hadn't gotten around to doing so, yet. However, this functionality was put in somewhat "recently", although I don't remember a commit mentioning it. I do know that it wasn't working up to about a month ago. Closing issue...

@ghost ghost closed this as completed Jan 1, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant