-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Inventory Refactor #1197
Major Inventory Refactor #1197
Conversation
Only one WorldObject per ObjectGuid can exist at a time. The normal reference comparison is fine. IComparable gives the wrong impression that a WorldObject with the same ObjectGuid can be defined/instantiated by two different objects at the same time.
Fix death items dropping properly Fix giving equipped items appearing in targets inventory
I have applied the 44 Files to my Server (latest build) and so far it appears to be good, My inventory is no longer spread all over hells half acre after a log out/ Login. However I tried to make a new character to check the Attuned and Bonded fix, I found I was UNable to give Jonathan My academy Exit Token, I was able to change that setting (114) Item (29335) in the DataBase from 1 to 0 and he excepted it. on a Good note I am NOT able to drop my Imp staff any longer. still testing more. |
The if statement at line 1438, within function GiveObjecttoNPC(), in Player_Inventory.cs is preventing giving Attuned items to NPCs. I believe Attuned was only directed towards player. Case and point are the Town Criers, which are AC's version of garbage collectors. Mostly, I believe NPCs will reject items, whether with a blanket statement about not knowing what to do with said item or with custom flavor text, if they aren't specifically set up via emotes to accept said items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from reviewing code and playtesting
Should be good for initial merge, unless @Warloxx01 or anyone has spotted anything else that can be cleaned up
I Started Back to work today but I did find that after you create a new char and equip his/her wand (after talking to Jonathan and receiving the oils and coat) then double click the oil and apply it to the wand (still equiped) that it will place the magic academy wand in your pack but doesnt remove the euiped wand. Once you try to remove it by drag and drop or double clicking the Academy wand to replace it nothing happens, it also can not be dropped on a Town Crier. Once you log out of the Game (fully not just to menu screen) and log back in the wand is gone and the academy wand can be equiped. "Last I checked" that was a day or two ago. |
Sorry I also forgot to add that (NOT every time) but now and then I will log back in and find myself in a different location then I logged out. Like I will go buy comps at the mage shop, run up to the LS and log out (all done in Holtburg) and when I log back in i will be back at the mage shop W/O the comps I bought before I logged out. |
I'll check out the first issue you reported. The second is likely unrelated. It sounds like there could be a db issue, the server isn't detecting the client logout properly and thus saving it, or the server isn't shutting down properly |
Ok, addressed the final issue. |
This fixes many of the inventory related issues.
It also simplifies the inventory code a bit.
It almost certainly introduces some new issues, so testing/feedback will be required.
Some none related inventory fixes: