Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACE Web/API projects should be converted to .net standard/core 2.0 #574

Closed
Mag-nus opened this issue Dec 4, 2017 · 1 comment
Closed

ACE Web/API projects should be converted to .net standard/core 2.0 #574

Mag-nus opened this issue Dec 4, 2017 · 1 comment
Labels
blocked:Help Wanted help wanted priority:medium

Comments

@Mag-nus
Copy link
Member

Mag-nus commented Dec 4, 2017

Most of the non web libraries of ACE have been converted to either .net standard 2.0 or .net core 2.0, and soon ACE be converted to .net core 2.0 as well.

We need an experienced web developer to migrate our web/api stuff.

The following projects need to be migrated:
ACE.Api
ACE.Api.Common
ACE.Api.Host
ACE.AuthApi
ACE.AuthApi.Host
ACE.Web

ACE.Api.Common should be priority as it's referenced directly by ACE.
@Mag-nus
Copy link
Member Author

Mag-nus commented Dec 11, 2017

Some suggestions from Rawaho regarding the API:
Using JWT from System.IdentityModel should work fine in .net core
Decomplicate the JWT implementation
The JwtManager can pretty much just be dropped for Microsoft.AspNetCore.Authentication
Drop Owin, RestSharp etc... for more .net core way of things
Remove the hosts.

Mag-nus added a commit that referenced this issue Dec 12, 2017
@Mag-nus
ACE switched over to .net core 2.0 (#579)
8263626 
* ACE switched over to .net core 2.0

ACE.Database\Extensions\DataTableExtensions.cs has been changed. Comments have been added and the new manual method is now the only method used when loading data.

ACE.Database\Database.cs added a debug message before and after the time consuming InitializePreparedStatements()

* Changelog updated noting secure auth breakage.
See this issue regarding updating our web/api stuff to be more .net core/standard compatible: #574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked:Help Wanted help wanted priority:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mag-nus @LtRipley36706