Adding the ability for players to buy houses #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mag-nus
reviewed
Sep 7, 2018
| WeaponAuraManaConv = 171 | ||
| WeaponAuraManaConv = 171, | ||
| // custom | ||
| HouseBuyTimestamp = 1000, |
There was a problem hiding this comment.
For ACE specific properties, we've been using the 9000+ range.
LtRipley36706
requested changes
Sep 7, 2018
| @@ -199,7 +203,7 @@ public static List<WorldObject> CreateNewWorldObjects(List<LandblockInstance> so | |||
| // TODO: Fix how objects are generated and linked | |||
|
|
|||
| // Code for new schema | |||
| foreach (var instance in sourceObjects.Where(x => x.IsLinkChild == false)) | |||
| foreach (var instance in sourceObjects/*.Where(x => x.IsLinkChild == false)*/) | |||
There was a problem hiding this comment.
This breaks links, should be restored before merge
| WeaponAuraManaConv = 171 | ||
| WeaponAuraManaConv = 171, | ||
| // custom | ||
| HouseBuyTimestamp = 9001, |
There was a problem hiding this comment.
PropertyInt.HousePurchaseTimestamp
|
FWIW I play tested this and the functionality being merged in this PR (purchasing a dwelling) looks good to me. Nice and exciting work @gmriggs! |
LtRipley36706
approved these changes
Sep 8, 2018
LtRipley36706
previously approved these changes
Sep 8, 2018
ghost
approved these changes
Sep 8, 2018
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.