New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revised pass at secure trade #1006

Merged

1 commit merged into ACEmulator:master from mcreedjr:trade-followup

Sep 10, 2018

Contributor

mcreedjr commented Sep 9, 2018

This is an update to my previous PR where basic secure trade functionality was implemented.

This PR does the following:

Verifies that trade partner is in range
Honors ignore all trade requests character option
Does not initiate when either party is in combat mode
Adds a few messages based on what I saw in retail PCAPs
Implemented GameEventDeclineTrade per PCAPs
Implements turn to when approaching trade partner

Probably a few other minor tweaks. Again, sorry for all of the open and closing PR noise. Git and I are often not friends.


          Revised pass at secure trade

ff36da6

ghost approved these changes

View reviewed changes

ghost merged commit 7df8b6e into ACEmulator:master

mcreedjr deleted the trade-followup branch

September 11, 2018 16:06

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment