Adding Sneak Attack skill for player combat #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
previously approved these changes
Sep 17, 2018
There was a problem hiding this comment.
Sneak Attack also affects magic damage, along with having ties to a trained or specialized Deception skill, see http://asheron.wikia.com/wiki/Sneak_Attack
ghost
previously approved these changes
Sep 19, 2018
ghost
reviewed
Sep 19, 2018
| @@ -251,6 +251,9 @@ public override void OnCollideObject(WorldObject _target) | |||
|
|
|||
| var player = ProjectileSource as Player; | |||
|
|
|||
| if (player != null) | |||
| player.LastHitSpellProjectile = spellStatMod; | |||
There was a problem hiding this comment.
Might want to use SpellBase, instead of StatMod. School originates in the SpellBase, which is pulled from the DAT. This field is an extra in the StatMod from the Database and so could get removed at any time.
ghost
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.