PlayerFactory #1031
Merged
PlayerFactory #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
spendallxp developer command added fixed SpendSkillXp so that the rankup is only applied if the SpendXp was successful |
ghost
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player/Character creation has been pulled out of CharacterHandler and added to a new PlayerFactory.
PlayerFactory includes a Create275HeavyWeapons function to help with load testing.
SpendAllXp has been added to Player_Xp.cs. A command handler can be added to allow use of this feature from in-game.
SpendAttributeXp, SpendVitalXp and SpendSkillXp no longer perform the work unless SpendXp was successful.
Player ctor from weenie no longer takes a Session object. Instead, only the AccountId is passed. This allows player creation without needing a session.