Adding multistrike weapons #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of Bandit weapons that can be used for testing. https://github.com/ACEmulator/ACE-World-16PY/search?q=TripleSlash will show a bunch of multistrike weapons. /ci 12053 for a Bandit Lightning Dagger
The animation hit frames were synced up reasonably well, but I am still looking for something in the data that can tell us exactly which animation frames to strike on.
Two-handed weapons are temporarily double-striking, while cleaving is still being added
Fixed a bug with fist combat mode being broken
Improved dual wielding combat so that the stats from the offhand weapon are used on the offhand attacks
Added more comments to Player_Melee
Fixed a bug where melee combat was not sending the 'AttackDone' network message when 'Auto-repeat' attacks option was disabled, with the power bar refilling (but not attacking again)
Fixed a bug where players could poke things with a staff, and other melee weapons that weren't supposed to thrust
Multistrike anomalies: shieldless combat cannot thrust, shield combat cannot slash (no animation links for these stances)