Fix Landblock loading. Portaling collisions are now much more responsive #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Teleport function
Furthermore, I believe we would be using different status values for the current state of ACE
This makes portaling around the world onto new landblocks much more responsive.
gmriggs
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, landblocks were loading all their assets in the ctor on the same thread.
Now, we off-load that loading onto separate threads and use an actionQueue to perform the resulting work in the landblock Tick.
Cleaned up the IsTeleporting flag. This should only be set/managed by the function that actually does the teleportation.
NetworkSession has timers that control how often we send messages to the client. The check was > but should have been >=. If an end-user wants to set a time of 0, > would not have worked.
Removed undeveloped/legacy LandBlockStatus code. This was used for our WinForms diagnostics app. We can redevelop this for the current state of ACE in the future if/when we have a diagnostics API.
Fixed a crash in EmoteManager from player being null (after teleportation)