More item destruction fixes #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename TryRemoveItemFromInventoryWithNetworking to TryRemoveItemFromInventoryWithNetworkingWithDestroy
|
I have tested the 14 files and it seems to have cured the items reappearing in my inventory... But, I also want to let you know there are other issues. NOT caused by this fix. Ill post them in a Bug report. But it looks like this fixed the reappearing issue. Ill do more testing. This did not fix the... |
|
Can you please create an issue for that as well? I am able to duplicate it. I think it's an issue with the notification system. I tested two of the same items, one through the process you mentioned and one just held in my inventory the whole time. The item properties were the same for all properties that mattered, between the two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain TimeToRot magic values of 0 and -1. They may have come from the weenie.
Destroy stacks that are consumed.
Destroy consumables when they're consumed.