Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving DatLoader for third-party apps #1092

Merged
merged 6 commits into from
Nov 22, 2018
Merged

Conversation

gmriggs
Copy link
Collaborator

@gmriggs gmriggs commented Nov 12, 2018

No description provided.

Copy link
Member

@Mag-nus Mag-nus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except the one comment I made regarding the UnpackArray change.

Source/ACE.DatLoader/UnpackableExtensions.cs Outdated Show resolved Hide resolved
Mag-nus
Mag-nus previously approved these changes Nov 16, 2018
Source/ACE.DatLoader/UnpackableExtensions.cs Outdated Show resolved Hide resolved
# Conflicts:
#	Source/ACE.DatLoader/DatManager.cs
@gmriggs gmriggs merged commit b215a34 into ACEmulator:master Nov 22, 2018
@gmriggs gmriggs deleted the datloader branch December 2, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants