Update LootGenerationFactory.cs #1205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LtRipley36706
previously approved these changes
Dec 31, 2018
gmriggs
approved these changes
Dec 31, 2018
gmriggs
requested changes
Jan 2, 2019
gmriggs
previously approved these changes
Jan 2, 2019
Creates loot for creatures that do not have a CreateList
gmriggs
previously approved these changes
Jan 2, 2019
LtRipley36706
previously requested changes
Jan 2, 2019
refactored a bit so that it could accomodate magical, nonmagical and mundane items.
Fixes chests for new loot system changes.
gmriggs
dismissed
LtRipley36706’s stale review
Both CreateList and DeathTreasureTier is used
gmriggs
approved these changes
Jan 4, 2019
LtRipley36706
requested changes
Jan 4, 2019
| @@ -55,7 +55,9 @@ private void SetEphemeralValues() | |||
| //Eventually these case statements would be linked to indivual treasure generators. Each one should be a different profile, but currently it will be the complete appropriate tier profile. | |||
| for (int i = 0; i < GeneratorProfiles.Count; i++) | |||
There was a problem hiding this comment.
in the generator profiles.. if the where create hasflag RegenLocationType.Treasure
it should do a look up in the death treasure table for that value of the wcid
if its just Contain, it needs no look up and that's the actual wcid
right now the code below is assuming anything below 500 is a death treasure which could be wrong
|
just created another PR. some things no longer needed to be touched from here, so just started clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates max damages per tier to be variable value. Previously, all weapons defaulted to their max value. This changes it so they are based on a bell curve for values within a range.