Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing incoming network commands should not instantiate ObjectGuids #1216

Merged
merged 86 commits into from
Jan 4, 2019
Merged

Parsing incoming network commands should not instantiate ObjectGuids #1216

merged 86 commits into from
Jan 4, 2019

Commits on Dec 14, 2018

  1. HandleActionStackableSplitTo3D cleanup

    @Mag-nus
    Mag-nus committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    bdfb0c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2018

  1. Container: Remove duplicate TryRemoveFromInventoryWithoutClear()

    @Mag-nus
    Mag-nus committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    9d3eb28 View commit details
    Browse the repository at this point in the history

  2. Always fix placement positions in Container SortWorldObjectsIntoInven… 

    …tory
    @Mag-nus
    Mag-nus committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    bf734bc View commit details
    Browse the repository at this point in the history

  3. HandleActionStackableSplitToContainer cleanup

    @Mag-nus
    Mag-nus committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    18c376e View commit details
    Browse the repository at this point in the history

  4. Inventory cleanup

    @Mag-nus
    Mag-nus committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    5b3eff0 View commit details
    Browse the repository at this point in the history

  5. Cleanup child object management (items held in hands)

    @Mag-nus
    Mag-nus committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    ebd9ee4 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. More player inventory progress

    @Mag-nus
    Mag-nus committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    da1244c View commit details
    Browse the repository at this point in the history

  2. Remove ActionChain.AddDelayTicks() (not used, we use time based)

    @Mag-nus
    Mag-nus committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    835b062 View commit details
    Browse the repository at this point in the history

  3. Fix opcode log warning in InboundMessageManager

    @Mag-nus
    Mag-nus committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    fe69cc7 View commit details
    Browse the repository at this point in the history

  4. HandleActionDropItem looking good on the new system

    @Mag-nus
    Mag-nus committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    785bb70 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    0cde173 View commit details
    Browse the repository at this point in the history

  6. HandleActionDropItem comments

    @Mag-nus
    Mag-nus committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    978bae3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. Fix PlayerEnterWorld exception when player has null Location

    @Mag-nus
    Mag-nus committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    6db30e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. More inventory progress

    @Mag-nus
    Mag-nus committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    6b3087c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    7a5b4ec View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    b6ce92f View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2018

  1. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    bf097d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    ee0064b View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2018

  1. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    a59080e View commit details
    Browse the repository at this point in the history

  2. minor cleanups

    @Mag-nus
    Mag-nus committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    249a03d View commit details
    Browse the repository at this point in the history

  3. Remove IComparable from WorldObject 

    Only one WorldObject per ObjectGuid can exist at a time. The normal reference comparison is fine. IComparable gives the wrong impression that a WorldObject with the same ObjectGuid can be defined/instantiated by two different objects at the same time.
    @Mag-nus
    Mag-nus committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    176e2ef View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. Inventory Progress

    @Mag-nus
    Mag-nus committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    ef6837c View commit details
    Browse the repository at this point in the history

  2. Fix stack size bug in Developer commands that use AddWeeniesToInventory

    @Mag-nus
    Mag-nus committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    8126548 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2018

  1. more inventory progress

    @Mag-nus
    Mag-nus committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    2a7585b View commit details
    Browse the repository at this point in the history

  2. More split progress

    @Mag-nus
    Mag-nus committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    69c887d View commit details
    Browse the repository at this point in the history

  3. more stack progress

    @Mag-nus
    Mag-nus committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    013c147 View commit details
    Browse the repository at this point in the history

  4. Use virtual MotionPickup

    @Mag-nus
    Mag-nus committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    4fc2c7e View commit details
    Browse the repository at this point in the history

  5. Inventory improvements

    @Mag-nus
    Mag-nus committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    0696573 View commit details
    Browse the repository at this point in the history

  6. more inventory progress

    @Mag-nus
    Mag-nus committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    d15c187 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    f619519 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2018

  1. player/npc give refactored

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    d58df94 View commit details
    Browse the repository at this point in the history

  2. Convert some obsolete inventory functions over to TryConsumeFromInven… 

    …toryWithNetworking
    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    3e88c48 View commit details
    Browse the repository at this point in the history

  3. All inventory functions converted

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    61e1484 View commit details
    Browse the repository at this point in the history

  4. Fix item decaying explosions

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    5ceb456 View commit details
    Browse the repository at this point in the history

  5. Fix player trade

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    32e97c6 View commit details
    Browse the repository at this point in the history

  6. More fixes

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    5081ea6 View commit details
    Browse the repository at this point in the history

  7. Fix giving partial stacks

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    07877cf View commit details
    Browse the repository at this point in the history

  8. Fix burden limitations when picking up items

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    4e3aede View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    ef6e2d6 View commit details
    Browse the repository at this point in the history

  10. Fix selling items

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    a38888e View commit details
    Browse the repository at this point in the history

  11. Inventory move to fixes

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    8b5a48e View commit details
    Browse the repository at this point in the history

  12. Cleanup TrySetChild

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    866b431 View commit details
    Browse the repository at this point in the history

  13. Don't decay IsStuck objects

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    8a959d2 View commit details
    Browse the repository at this point in the history

  14. Don't allow pickup of IsStuck items

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    5dfb356 View commit details
    Browse the repository at this point in the history

  15. Fix moving equipped items around

    @Mag-nus
    Mag-nus committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    0812222 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. Weapons now work

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    bd1670d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    436d7ed View commit details
    Browse the repository at this point in the history

  3. Fix player location null restore

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    d39e034 View commit details
    Browse the repository at this point in the history

  4. Add back HeritageBonuses to Player_Skills

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    5f5ef6c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    09e0620 View commit details
    Browse the repository at this point in the history

  6. Fix equipment spell/dispell on equip/dequip

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    7ed2b11 View commit details
    Browse the repository at this point in the history

  7. Fix non-selectable wielded items from showing on the player model

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    d632b4d View commit details
    Browse the repository at this point in the history

  8. Fix wield/unwield sound for equipped items that aren't childeren

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    5e6f73a View commit details
    Browse the repository at this point in the history

  9. TrySetChild should ClearChild if it's not a valid child.

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    6c62155 View commit details
    Browse the repository at this point in the history

  10. Fix missile ammo as child

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    d0a74c6 View commit details
    Browse the repository at this point in the history

  11. Send DeleteObject instead of PickupEvent on Dequip. This fixes disapp… 

    …earing weapon on relog
    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    e323c2f View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    9df9c5d View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2018

  1. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    e4a156a View commit details
    Browse the repository at this point in the history

  2. Couple notes where item recovieres should go

    @Mag-nus
    Mag-nus committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    7d00e3f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    7ef7522 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2019

  1. Hopefully this fixes the ammo being displayed incorrectly

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    85e41c4 View commit details
    Browse the repository at this point in the history

  2. Couple inventory fixes 

    Fix death items dropping properly
Fix giving equipped items appearing in targets inventory
    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    cd4e861 View commit details
    Browse the repository at this point in the history

  3. Allow close container that has no viewer

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    7869eb4 View commit details
    Browse the repository at this point in the history

  4. Couple more log warnings for potential lost items

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    9e3e7bf View commit details
    Browse the repository at this point in the history

  5. Add static methods to ObjectGuid

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    a155f50 View commit details
    Browse the repository at this point in the history

  6. Use ObjectGuid.IsPlayer instead of creating a new ObjectGuid

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    b2f9d09 View commit details
    Browse the repository at this point in the history

  7. ACE.Server.Network.GameAction.Actions cosmetic cleanup

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    5b9c3a1 View commit details
    Browse the repository at this point in the history

  8. Network GameActions no longer create and pass ObjectGuids. Now they p… 

    …ass uints

The idea here is that incoming network packet handlers should be doing the bare minimum to parse the packet.

The handler of the action should be what determines of an ObjectGuid is needed, or a uint is sufficient.
    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    6abf7c0 View commit details
    Browse the repository at this point in the history

  9. Network.Handlers switched from ObjectGuid -> uint

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    03517d6 View commit details
    Browse the repository at this point in the history

  10. Another instance of ObjectGuid used in the network actions removed

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    cf57a04 View commit details
    Browse the repository at this point in the history

  11. More networking ObjectGuids switched to uints

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    775a68b View commit details
    Browse the repository at this point in the history

  12. missed a file

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    11987b8 View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    661222b View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    9ec0e21 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into NetworkingCleanup

    @Mag-nus
    Mag-nus committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    1708eeb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    62b2b0d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into NetworkingCleanup

    @Mag-nus
    Mag-nus committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    778f2a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Attuned check removed for GiveObjecttoNPC

    @Mag-nus
    Mag-nus committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    396b79e View commit details
    Browse the repository at this point in the history

  2. Don't consume unlimited use gems

    @Mag-nus
    Mag-nus committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    da0384c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    b761d0d View commit details
    Browse the repository at this point in the history

  4. Fix HandleDestroyBonded

    @Mag-nus
    Mag-nus committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    7bb7ce0 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Fix destroying equipped items when consumed

    @Mag-nus
    Mag-nus committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    a3a6cdf View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into MoreInventoryWork

    @Mag-nus
    Mag-nus committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    5078cc9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'MoreInventoryWork' into NetworkingCleanup

    @Mag-nus
    Mag-nus committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    3ce89de View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into NetworkingCleanup

    @Mag-nus
    Mag-nus committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    43280ca View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into NetworkingCleanup

    @Mag-nus
    Mag-nus committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    a753067 View commit details
    Browse the repository at this point in the history