World object fixes #137
World object fixes #137
Conversation
Source/ACE/Entity/Model.cs
Outdated
| /// Index of Model being replace | ||
| /// </summary> | ||
| public byte Index { get; } | ||
| /// <summary> |
There was a problem hiding this comment.
empty line between fields please.
| /// <summary> | ||
| /// Index of model to replace texture. | ||
| /// </summary> | ||
| public byte Index { get; } |
There was a problem hiding this comment.
empty line between fields please
| @@ -31,7 +31,7 @@ public GameMessageCreateLifestone(Player player) : base(GameMessageOpcode.Object | |||
| Position newPosition = new Position(player.Position.Cell, player.Position.Offset.X + dx, player.Position.Offset.Y + dy, player.Position.Offset.Z + 0.5f, 0f, 0f, 0f, 0f); | |||
|
|
|||
| var weenie = WeenieHeaderFlag.Usable | WeenieHeaderFlag.BlipColour | WeenieHeaderFlag.Radar | WeenieHeaderFlag.UseRadius; | |||
| ImmutableWorldObject wo = new ImmutableWorldObject(ObjectType.LifeStone, new ObjectGuid(nextObjectId++, GuidType.None), "Life Stone", ObjectDescriptionFlag.LifeStone, weenie, newPosition); | |||
| ImmutableWorldObject wo = new ImmutableWorldObject(ObjectType.LifeStone, new ObjectGuid(GuidManager.NewStaticObjectGuid()), "Life Stone", 1, ObjectDescriptionFlag.LifeStone, weenie, newPosition); | |||
There was a problem hiding this comment.
If you're not going to implement WCID at this point, don't stub bad data. We're close to using it properly.
There was a problem hiding this comment.
I am not sure how to fix it, but the way its in ace now its not named correctly.
Also, passing a 1, its required now.. now sure the proper way to use this.. but interested..
can we keep this now until its in properly ?
There was a problem hiding this comment.
i guess. just another merge conflict for the landblock PR is all.
| @@ -23,7 +23,7 @@ public enum PhysicsDescriptionFlag | |||
| DefaultScriptIntensity = 0x004000, | |||
| Position = 0x008000, | |||
| Movement = 0x010000, | |||
| AnimationFrame = 0x200000, | |||
| AnimationFrame = 0x020000, | |||
| Translucency = 0x400000 | |||
There was a problem hiding this comment.
Og II also fixed this to have Translucency of 0x040000
Source/ACE/Entity/Player.cs
Outdated
| @@ -197,7 +197,7 @@ public Player(Session session) : base(ObjectType.Creature, session.CharacterRequ | |||
| GameData.Usable = Usable.UsableObjectSelf; | |||
|
|
|||
| SetPhysicsState(PhysicsState.IgnoreCollision | PhysicsState.Gravity | PhysicsState.Hidden | PhysicsState.EdgeSlide, false); | |||
| PhysicsData.PhysicsDescriptionFlag = PhysicsDescriptionFlag.CSetup | PhysicsDescriptionFlag.MTable | PhysicsDescriptionFlag.Stable | PhysicsDescriptionFlag.Petable | PhysicsDescriptionFlag.Position; | |||
| PhysicsData.PhysicsDescriptionFlag = PhysicsDescriptionFlag.CSetup | PhysicsDescriptionFlag.MTable | PhysicsDescriptionFlag.Stable | PhysicsDescriptionFlag.Petable | PhysicsDescriptionFlag.Position;// | PhysicsDescriptionFlag.Movement; | |||
There was a problem hiding this comment.
cleanup on aisle 200...
| /// </summary> | ||
| public abstract class MutableWorldObject : WorldObject | ||
| public abstract class MutableWorldObject : WorldObject/// </summary> | ||
|
|
There was a problem hiding this comment.
added whitespace, butchered the xml doc. fix please.
|
Cleaned up |
|
MutableWorldObject xml doc header.... |
World Object Fixes + Start of Global Guid Manager