Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LootGenerationFactory to support TOD #1416

Merged
4 commits merged into from Feb 5, 2019
Merged

Change LootGenerationFactory to support TOD #1416

4 commits merged into from Feb 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2019

  • Update LootGenerationFactory to support the updated TOD weapon weenies

@ghost
Copy link
Author

ghost commented Feb 5, 2019

In the case of melee weapons, UiEffects property should not be defaulted to 0, as there are separate weenies for each loot weapon type for each element that set the default. Only set UiEffects to 1, if the item contains spells, thus overriding the weenie default. Missile weapons and casters have the element externally applied, so a default should be set to zero, in these two cases.

Copy link
Collaborator

@dgatewood dgatewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good for weenies, etc. Once approved, if the mods arent adjusting past the original values, we can fix that.

@ghost ghost merged commit a25cf4b into ACEmulator:master Feb 5, 2019
@ghost ghost deleted the LootFactoryMod branch February 12, 2019 00:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants