EncumbranceVal and Value should not be ephemeral by default #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EncumbranceVal is now ephemeral only for containers Value is now ephemeral only for non-creature containers. This allows items to persist their EncumbranceVal and Value changes to the database. For containers, they will retain their original (default) value from the database, load that into the ephemeral dictionary and build from there. Those changes will then be lost and reset next time the object is loaded.
ghost
previously approved these changes
Feb 14, 2019
LtRipley36706
approved these changes
Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EncumbranceVal is now ephemeral only for containers
Value is now ephemeral only for non-creature containers.
This allows items to persist their EncumbranceVal and Value changes to the database.
For containers, they will retain their original (default) value from the database, load that into the ephemeral dictionary and build from there. Those changes will then be lost and reset next time the object is loaded.