Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding centralized damage calculation function #1446

Merged
merged 13 commits into from
Feb 20, 2019

Conversation

gmriggs
Copy link
Collaborator

@gmriggs gmriggs commented Feb 16, 2019

The various CalculateDamage functions were getting a bit scattered, so this adds a common DamageEvent class / CalculateDamage() function that handles all scenarios

Previously, there were 3 separate variations of CalculateDamage:

  • Players attacking monsters
  • Players attacking other players (PvP)
  • Monsters attacking players / monsters

This merges everything into 1 common function that handles everything for all physical damage calculation

ghost
ghost previously approved these changes Feb 16, 2019
@gmriggs gmriggs merged commit a705272 into ACEmulator:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant