Change the AdminObjectFactory to LifestoneObjectFactory, add PortalOb… #145
Conversation
…jectFactory, add LifestoneType and PortalType Enums, remove unneeded GameMessageCreateLifestone, and remove the leftover DebugAssert command in ObjectGuid
There was a problem hiding this comment.
Going to leave this comment because I know you'll get it in an email... I like the changes, but I want to caution us against rabbit-holing down a factory-per-object-type paradigm. This is helpful stuff to get people involved and aware of how to do things properly, but down the road this will all go through a generic static object factory that doesn't care about what type it is - it will eventually load all the WCId data from a database table and populate the object automatically for us.
Otherwise, looks great and takes a step in the right direction towards more generalized object factory patterns.
| [CommandHandler("createportal", AccessLevel.Developer, CommandHandlerFlag.RequiresWorld)] | ||
| public static void CreatePortal(Session session, params string[] parameters) | ||
| { | ||
| LandblockManager.AddObject(PortalObjectFactory.CreatePortal(1234, session.Player.Position.InFrontOf(3.0f),"Test Portal",PortalType.Purple)); |
There was a problem hiding this comment.
whitespace consistency - spaces after commas. not going to block a PR over it, but want you to know. stylecop rules coming down the pipe will enforce this in the future.
ghost
deleted the
…jectFactory, add LifestoneType and PortalType Enums, remove unneeded GameMessageCreateLifestone, and remove the leftover DebugAssert command in ObjectGuid