Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coelesced Aetheria to loot drops #1632

Closed
wants to merge 4 commits into from
Closed

Add Coelesced Aetheria to loot drops #1632

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2019

  • Add Coelesced Aetheria to loot drops
  • Adjust LootGenerationFactory.GetValue() to take the inherent weenie value of items into account, rather than a seemingly arbitrary random value

@ghost
Copy link
Author

ghost commented Apr 2, 2019

Even if the quests to activate the slots are not available, both Janier al-Evv that sells Aetheria Desiccant and Cypher that exchanges stacks of Aetheria powder for MMD notes or Mana Forge keys are present in Xarbydun.

// According to wiki, Weapon Mana Forge chests don't drop Aetheria
// Otherwise, 50% chance to drop a Coalesced Aetheria
if (aetheriaGenerated == false && profile.Tier > 4 && lootBias != LootBias.Weapons)
aetheriaDropChance = ThreadSafeRandom.Next(1, 2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reference for the 50% drop rate for Aetheria?

This seems like it would be an extremely high drop rate...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any reference to the amount that it drops. There are statements to where it won't drop.

The 50% chance is for each roll in the magic loot category to get either an Aetheria or other magic containing item. Only one is allowed to generate per call into the loot generation, so even on multiple rolls, only a max of one Aetheria will be generated. While play testing this patch in multiple loot tiers, the Aetheria spawned less than the Summon Essense do. With any less chance to generate an Aetheria, it felt too sparse. At any rate, it is just the first stab at getting them into the mix. If others that may have an even better sense of it say its still too high, it can be decreased.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did make a generalization and inference from a note in the wiki for Steel Chests, in that either Coalesced Aetheria or a weapon drops for its two non-scroll or mana charge slots.

Copy link
Author

@ghost ghost Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am certainly open to changing it, if the drop rate still feels too high.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can try playtesting when i get a chance

knee-deep in bug fixes for the live server atm...

@ghost ghost closed this Apr 11, 2019
@ghost ghost deleted the CoelescedAetheria branch April 11, 2019 05:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant