Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contingent: consolidated the session collections #1662

Closed
wants to merge 3 commits into from
Closed

Contingent: consolidated the session collections #1662

wants to merge 3 commits into from

Conversation

fartwhif
Copy link
Collaborator

@fartwhif fartwhif commented Apr 7, 2019

No description provided.

Mag-nus
Mag-nus requested changes Apr 7, 2019
View reviewed changes
Copy link
Member

@Mag-nus Mag-nus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for testing the CE issue, it should be merged into CE.

It shouldn't go into master. It's a much less performant way to manage sessions.

@fartwhif fartwhif changed the title consolidated the session collections Contingent: consolidated the session collections Apr 8, 2019
@fartwhif
Copy link
Collaborator Author

fartwhif commented Apr 8, 2019 •
edited

Merge is contingent upon whether or not it ends up fixing the "Network issues causing intermittent client drops" issue. If it doesn't then close this without merge. If it doesn't then the session collections can probably be ruled out as the cause.

@fartwhif
Copy link
Collaborator Author

fartwhif commented Apr 12, 2019 •
edited

#1687 supersedes this and was merged

@fartwhif fartwhif closed this Apr 12, 2019
@fartwhif fartwhif reopened this Apr 13, 2019
@fartwhif fartwhif requested a review from Mag-nus April 13, 2019 22:34
@fartwhif
Copy link
Collaborator Author

1726 supersedes this

@fartwhif fartwhif closed this Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mag-nus Mag-nus Awaiting requested review from Mag-nus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fartwhif @Mag-nus @LtRipley36706